LG-11054 Updates to in person proofing specs#9863
Conversation
| include RenderConditionConcern | ||
| include UspsInPersonProofing | ||
| include EffectiveUser | ||
| include UspsInPersonProofing |
There was a problem hiding this comment.
this was a duplicate line, see line 8
| expect(page).to have_field(t('in_person_proofing.form.state_id.zipcode'), with: '12345-6789') | ||
| click_idv_continue | ||
| expect(page).to have_current_path(idv_in_person_ssn_url) | ||
| context 'when visiting state id for the first time' do |
There was a problem hiding this comment.
this additional test keeps this spec in line with other step spec files
| end | ||
| end | ||
|
|
||
| context 'when updating by visiting state id from verify info pg' do |
There was a problem hiding this comment.
thoughts? should this spec exist here or should it only exist in the verify_info spec as that is where a user initiates the update.
There was a problem hiding this comment.
Is there a reasonable expectation that within the context of this test, the result may be different (due to variables) than the verify_info spec?
There was a problem hiding this comment.
no, nothing should be different.
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I didn't get a chance to finish going through this today, so I'm just leaving the couple unimportant comments I had so far.
| end | ||
| end | ||
|
|
||
| context 'transliteration' do |
There was a problem hiding this comment.
renamed and moved to address_spec and state_id_step_spec
svalexander
changed the title
svalexander
changed the title
| expect(page).to have_text(InPersonHelper::GOOD_ADDRESS2) | ||
| expect(page).to have_text(InPersonHelper::GOOD_CITY) | ||
| expect(page).to have_text(InPersonHelper::GOOD_ZIPCODE) | ||
| expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT_STATE) |
There was a problem hiding this comment.
Is this a new field that we weren't checking for before or was this a wee oversight?
There was a problem hiding this comment.
I think it was an oversight as it existed on the page previously but we werent checking for it in the spec
6 participants
🎫 Ticket
Link to the relevant ticket:
LG-11054
🛠 Summary of changes
This ticket was to audit the in person specs and begin to make updates. This pr makes some changes to the in_person, address, and state_id feature specs.