Skip to content

LG-11882 (Step 3): Drop disposable_domains table#9896

Merged
aduth merged 1 commit intomainfrom
aduth-lg-11882-drop-disposable-domains
Jan 22, 2024
Merged

LG-11882 (Step 3): Drop disposable_domains table#9896
aduth merged 1 commit intomainfrom
aduth-lg-11882-drop-disposable-domains

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jan 10, 2024

🎫 Ticket

LG-11882

🛠 Summary of changes

Drops the database table disposable_domains, after last references were removed in #9895.

Do not merge: This should only be merged after #9895 is live in production.

📜 Testing Plan

Repeat testing plan from #9747 to verify no regressions in current logging.

@aduth aduth requested a review from a team January 10, 2024 14:32
@aduth aduth force-pushed the aduth-lg-11882-disposable-domains-code-path branch 2 times, most recently from 721375e to fe27bd3 Compare January 10, 2024 18:20
@aduth aduth force-pushed the aduth-lg-11882-drop-disposable-domains branch from 567c69b to 9744331 Compare January 10, 2024 18:21
Base automatically changed from aduth-lg-11882-disposable-domains-code-path to main January 11, 2024 20:18
changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
@aduth aduth force-pushed the aduth-lg-11882-drop-disposable-domains branch from 9744331 to 0c4327f Compare January 11, 2024 20:19
@aduth aduth requested review from a team and removed request for a team January 22, 2024 13:05
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! 👍

@aduth aduth merged commit 319ad90 into main Jan 22, 2024
@aduth aduth deleted the aduth-lg-11882-drop-disposable-domains branch January 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants