LG-11433: FT unlock redirect to options page if eligible only#9835
LG-11433: FT unlock redirect to options page if eligible only#9835
Conversation
There was a problem hiding this comment.
Question: There are many ways that a user might be prompted for MFA, such as reauthentication. Can we always rely on the session value being present in those other scenarios? My thinking is yes since someone's session should always begin from the sign-in page, but I wanted to ask to double-check.
There was a problem hiding this comment.
I think it should for sure, but I dont know if in reauthenthication we want this? Maybe we can remove it when its directed.
| ) | ||
| end | ||
|
|
||
| def mock_setup_eligible_user_device |
There was a problem hiding this comment.
- Should we just update the default user agent string for mobile to be able to avoid this?
- I'd suggest incorporating "webauthn" somewhere in the name of the method, even if it's in
WebauthnHelper, to clarify at call-sites, and for consistency with other methods in this file.
…nlock-only-if-eligible
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Looking good, couple build failures look related
app/controllers/two_factor_authentication/webauthn_verification_controller.rb
Outdated
Show resolved
Hide resolved
| password = user.password | ||
| allow(UserMailer).to receive(:new_device_sign_in).and_call_original | ||
| visit new_user_session_path | ||
| set_hidden_field('platform_authenticator_available', 'true') |
There was a problem hiding this comment.
Per some of the build failures, maybe we should set this as the default behavior for signing in in the existing spec helper(s)?
mdiarra3
changed the title
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple minor comments, but LGTM overall 👍
app/controllers/two_factor_authentication/webauthn_verification_controller.rb
Show resolved
Hide resolved
…nlock-only-if-eligible
3 participants
🎫 Ticket
LG-11433: Redirect if ineligible for F/T Unlock
🛠 Summary of changes
This adds an additional check when the user is showing F/T unlock first to be redirected to the options page.