Skip to content

LG-11882: Rename Rake task for disposable email domains#9910

Merged
aduth merged 1 commit intomainfrom
aduth-lg-11882-disposable-email-domains-rake
Jan 22, 2024
Merged

LG-11882: Rename Rake task for disposable email domains#9910
aduth merged 1 commit intomainfrom
aduth-lg-11882-disposable-email-domains-rake

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jan 11, 2024

🎫 Ticket

LG-11882

🛠 Summary of changes

Makes a few revisions to the Rake script for populating the disposable email domains table.

  1. Per intent of the ticket, rename as "disposable email domains"
  2. Avoid quotes in usage example which can produce an error when included
  3. Reword from "URL" to "path" since the expected parameter is not a fully-qualified URL, it is expected to be a path fragment handled by Identity::Hostdata.secrets_s3.readfile

Once merged, I will plan to update the corresponding rollplan document accordingly.

changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
@aduth aduth requested a review from a team January 11, 2024 20:25
@aduth aduth merged commit 98bbefb into main Jan 22, 2024
@aduth aduth deleted the aduth-lg-11882-disposable-email-domains-rake branch January 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants