Document disposable email domain analytics parameter#9912
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks like the spec needs to be revised to include added value.
I see, the spec will be done with #9747:
zachmargolis
approved these changes
Jan 16, 2024
changelog: Internal, Documentation, Add missing parameter to user registration analytics event
1ded309 to
d1c00e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
user_registration_completemethod signature to include thedisposable_email_domainargument, which may be passed as a result of this code added in #9747:identity-idp/app/controllers/sign_up/completions_controller.rb
Lines 104 to 106 in 43e0c4a
Why?
analytics_events.rb(e.g. this was motivated by my own pursuit to jog my memory about which event this was logged on)📜 Testing Plan
After merged, observe the parameter is visible in Analytics Events documentation
Build should pass