LG-11946: Delete Account Page content update#9905
Merged
Conversation
…r account reset to make more sense
Contributor
Author
|
blocked by content freeze. |
aduth
approved these changes
Jan 11, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 As flagged by build, we'll need to wait for content freeze to lapse before merging.
Comment on lines
+14
to
+15
| <p><%= t('account_reset.recovery_options.check_webauthn_platform_info') %></p> | ||
| <p><%= t('account_reset.recovery_options.use_same_device') %></p> |
Contributor
There was a problem hiding this comment.
I don't really have a strong preference one way or the other, but another way we've done multiple paragraphs of text is by using an array in the YAML file and looping over it in the template.
identity-idp/app/views/account_reset/request/show.html.erb
Lines 5 to 7 in 809a5a6
The main upside would be to keep the related content together in the YAML files.
Contributor
Author
There was a problem hiding this comment.
huh interesting will take a look
…e-account-confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-11946
🛠 Summary of changes
Update the content pertaining to Platform Authentication in account deletion process to be a little bit more universal and make mores sense.
👀 Screenshots