Merged
Conversation
* Added profile id in AccountsController * Use `User#active_or_pending_profile` in `AccountsController` changelog: Internal,use pii from the correct profile, Explicitly pass profile id when fetching PII for user account page.`
Previously, we used an allowlist for specific subdomains on identitysandbox.gov. This means that Gitlab review apps are not able to reveal GPO codes for users testing GPO functionality. This update makes it so all apps running on identitysandbox.gov reveal their GPO code. changelog: Internal, Identity verification, Allow testing GPO verification in sandbox environments.
* spec helper for setting up preconditions in idv flow * Start using FlowPolicyHelper for flow_policy_spec.rb * Fix in person flow_policy_helper and specs * Fix phone and enter_password specs for flow_policy_helper * cleaned up some logic around the phone step preconditions * check vendor_phone_confirmation instead of user_phone_confirmation_session * Rename stub_up_to_key to stub_up_to and make key an unnamed parameter --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
…ch setup (#9696) * modify content for success banner changelog: User-facing Improvements, F/T unlock, improve messaging on successful setup * add title * add webauthn platform info * normalize yaml * create logic for webauthn platform setup success changelog: User-Facing Improvements, F/T unlock, change messaging for F/T success on sign up * add tests * Add instructions after F/T unlock * change key for info message changelog: User-Facing Improvements, F/T unlock, improve messaging on successful setup * add question mark for method * Empty-Commit changelog: User-Facing Improvements, authentication method setup success, add tailored messaging for successful F or Touch unlock setup * add tests for heading and content logic * correct test for info * add test for tailored localized title * Something is not right, something is quite wrong * Something is not right, something is quite wrong * restructure presenter test * edit descriptions of tests
* Add support for client-side OIDC redirect changelog: Internal, OpenID Connect, Add support for client-side OIDC redirect --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
**Why**: We get occasional rate limit errors when running this report in production, reducing the number of concurrent queries should hopefully help avoid hitting this limit **Background**: The parallelism was added in #9212, when we only ran the report on developer boxes so that it would complete in under the 30min time window for an AWS vault session changelog: Internal, Reporting, Reduce parallelism of Cloudwatch queries
…9721) * Mark in person FSM steps incomplete when restarting flow Otherwise they cannot be re-entered changelog: Bug Fixes, Identity verification in person back button, allow in person flow to be repeated after backing up and resubmitting an earlier step --------- Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
* Set idv_level when creating new profiles changelog: Internal, Identity verification, Write idv_level when saving profiles. * Add idv_level to Profile factories * Update spec/services/idv/profile_maker_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update spec/services/idv/profile_maker_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update spec/services/idv/profile_maker_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Reformat if statement --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Remove rule for idp_ci changes in build-ci-image Force rebuild * Revert "Remove rule for idp_ci changes in build-ci-image" This reverts commit 891eb21. * Update GitLab CI SHA from 891eb21 * Update Quibble dependency for latest Node.js 18.x, 20.x support changelog: Internal, Dependencies, Update dependencies for latest Node.js compatibility * Update yarn.lock
* add florida hint * changelog: User-Facing Improvements, State id, add florida hint text * alphabetize states in state id view
…fter error (#9692) * changelog: Bug Fixes, Authentication, Redirect with the sp already loaded for the user * add spec to ensure things arent broken * branded experience * change test title name
* changelog: User-Facing Improvements, Reporting, Update user count report
Add aria labelledby to inputs on TOTP setup page changelog: User-Facing Improvements, Authentication, Update accessibility related to TOTP fields
changelog: Bug Fixes, Reporting, Prevents value from being null
changelog: Internal, Review apps, Write deploy.json file for review apps
changelog: Internal, Reporting, Expand MKMR Proofing Rate Report
* Pass profile id to cacher.fetch in generate_personal_key changelog: Internal, Identity verification, Ensure correct PII encrypted in PersonalKeyController * Allow passing new personal key into Profile::encrypt_recovery_pii * Re-encrypt other profiles with newly issued personal key * Try setting version_headers_enabled for review apps * Revert "Try setting version_headers_enabled for review apps" This reverts commit 1ba20f2.
* Add rake task to backfill Profile idv_level Temporary task to be used in a roll plan. [skip changelog] * Use in_batches to process records in batches Minimize the size of individual updates (also add some reporting along the way)
* Fix misnamed spec files * Add lint for incorrectly named spec files changelog: Internal, Automated Testing, Add lint for misnamed spec files * Improve formatting of commands
changelog: Internal, Automated Testing, Fix accessibility matcher error message logic
changelog: Internal, Automated Testing, Improve effectiveness of spec JSDOM reset
…esting (#9739) * Add SKIP_BUILD flag for skipping asset build in development changelog: Internal, Automatic Testing, Add flag for skipping asset build in development * Document asset compilation skip for tests
* changelog: User-Facing Improvements, Webauthn, Remove device nickname workflow - autopopulate * use hidden field for platform authenticator nickname * bring device decorator into spec * fix lint * refactor how browser agent is captured * remove fill in nickname helper from webauthn platform based test * remove fill in nickname from test * remove fill in nickname from test * correct number of arguments error * rename method * rename method * reverse name logic to make it more readable * move device nice name to service class * formatting, add device name service to device decorator * append date string if device name is already set * lint fix * make naming consistent for device * remove hyphen from duplicate device naming * revise form setup spec to match module * update device decorator spec to include device name service * add test coverage for name_is_unique changes and change duplicate name fix * add test to validate form does not appear on webauth platform setup * use an incremental number to label duplicate device name * put device name service into its own spec * fix increment syntax * reorder spec pretext values and add context for non-platform webauthn * correct naming increment syntax * revise test to account for duplicate webauthn platform names * lint fix * remove unneeded before do block * remove unneeded code * improve test coverage, remove redundant condition from setup * lint fix * Update spec/services/device_name_spec.rb Correct use of class member labeling Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
mdiarra3
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal