Skip to content

LG-11613: Improved content informing user of success with face or touch setup#9696

Merged
jmdembe merged 19 commits intomainfrom
jd-LG-11613-improve-ft-unlock-success-messaging
Dec 6, 2023
Merged

LG-11613: Improved content informing user of success with face or touch setup#9696
jmdembe merged 19 commits intomainfrom
jd-LG-11613-improve-ft-unlock-success-messaging

Conversation

@jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Dec 4, 2023

🎫 Ticket

LG-11613: Improved content informing user of success with face or touch setup

🛠 Summary of changes

This PR adds tailored language for when a user sets F/T unlock as their primary authentication method.

📜 Testing Plan

Pre-requisite: Create a new account

  • Select "Face or Touch unlock" on the authentication methods setup screen
  • Follow instructions to set up Face or Touch Unlock
  • On success, see the tailored message for successful setup. Also note that the title on the tab now reads "Face or Touch unlock added"

Optional (this is the current state and the desired behavior for all other authentication methods)
Pre-requisite: Create a new account

  • Select any method that is not Face or Touch Unlock
  • Follow instructions to set up the authentication method
  • On success, take a look at the page in its current state. This will be the behavior for all other methods once the setup is successful

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before: Current state of the You’ve added your first authentication method! screen
After: Proposed state of Face or Touch unlock added

changelog: User-facing Improvements, F/T unlock, improve messaging on successful setup
changelog: User-Facing Improvements, F/T unlock, change messaging for F/T success on sign up
@jmdembe jmdembe changed the title Jd-LG-11613-improve-ft-unlock-success-messaging LG-11613: Improved content informing user of success with face or touch setup Dec 4, 2023
@jmdembe jmdembe requested a review from a team December 4, 2023 15:38
@jmdembe jmdembe marked this pull request as draft December 4, 2023 15:38
changelog: User-Facing Improvements, F/T unlock, improve messaging on successful setup
changelog: User-Facing Improvements, authentication method setup success, add tailored messaging for successful F or Touch unlock setup
@jmdembe jmdembe force-pushed the jd-LG-11613-improve-ft-unlock-success-messaging branch from 17f54e9 to e66c104 Compare December 4, 2023 17:20
@jmdembe jmdembe marked this pull request as ready for review December 4, 2023 18:05
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmdembe jmdembe merged commit 6a87cb7 into main Dec 6, 2023
@jmdembe jmdembe deleted the jd-LG-11613-improve-ft-unlock-success-messaging branch December 6, 2023 19:59
@jmhooper jmhooper mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants