LG-11696: Associate TOTP setup fields with visual label#9716
Merged
Conversation
changelog: User-Facing Improvements, Authentication, Update accessibility related to TOTP fields
aduth
approved these changes
Dec 6, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Tested in Chrome accessibility inspector and macOS Voiceover and confirmed the labels are still associated with the fields 👍
Left a couple comments, but primarily interested in the test coverage on the component.
| Nickname | Code |
|---|---|
 |
 |
 |
 |
jc-gsa
force-pushed
the
LG-11696-accessibility-TOTP-setup-fields
branch
from
321e025 to
1f88e38
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG11696
🛠 Summary of changes
Adds
aria-labelledbyto input fields on the page/authenticator_setup.📜 Testing Plan