Skip to content

LG-11605 add florida hint text#9718

Merged
svalexander merged 3 commits intomainfrom
shannon/lg-11605-florida-hint-text
Dec 7, 2023
Merged

LG-11605 add florida hint text#9718
svalexander merged 3 commits intomainfrom
shannon/lg-11605-florida-hint-text

Conversation

@svalexander
Copy link
Contributor

@svalexander svalexander commented Dec 6, 2023

🎫 Ticket

LG-11605

🛠 Summary of changes

Add id number hint text for Florida.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through ipp flow and arrive at state id page
  • Scroll down to "issuing state" drop down
  • Confirm hint under id number is the default text
  • Select "Florida"
  • Confirm hint under "id number" is the Florida-specific text
  • Select another state
  • Confirm hint under "id number" is the default text
  • Change language to es
  • Confirm hint under id number is the default text
  • Select "Florida"
  • Confirm hint under "id number" is the Florida-specific text
  • Select another state
  • Confirm hint under "id number" is the default text
  • Change language to fr
  • Confirm hint under id number is the default text
  • Select "Florida"
  • Confirm hint under "id number" is the Florida-specific text
  • Select another state
  • Confirm hint under "id number" is the default text

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

En: Screen Shot 2023-12-06 at 12 39 19 PM
Es: Screen Shot 2023-12-06 at 12 39 42 PM
Fr: Screen Shot 2023-12-06 at 12 40 26 PM

Comment on lines 130 to +131
['TX', t('in_person_proofing.form.state_id.state_id_number_texas_hint')],
['FL', t('in_person_proofing.form.state_id.state_id_number_florida_hint')],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of keeping everything after the default value alphabetized?

Suggested change
['TX', t('in_person_proofing.form.state_id.state_id_number_texas_hint')],
['FL', t('in_person_proofing.form.state_id.state_id_number_florida_hint')],
['FL', t('in_person_proofing.form.state_id.state_id_number_florida_hint')],
['TX', t('in_person_proofing.form.state_id.state_id_number_texas_hint')],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense! i'll update

@svalexander svalexander changed the title add florida hint LG-11605 add florida hint text Dec 6, 2023
Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you Shannon

@svalexander svalexander merged commit 98ea229 into main Dec 7, 2023
@svalexander svalexander deleted the shannon/lg-11605-florida-hint-text branch December 7, 2023 13:41
@jmhooper jmhooper mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants