Jmax/lg 11533 read pii from session for account presenter#9637
Merged
Jmax/lg 11533 read pii from session for account presenter#9637
Conversation
changelog: Internal,PII caching,Explicitly pass profile id when fetching PII for user account page.`
jmax-gsa
force-pushed
the
jmax/LG-11533-read-pii-from-session-for-account-presenter
branch
from
a54f5c3 to
1cd7e6a
Compare
matthinz
reviewed
Nov 22, 2023
|
|
||
| expect(page).to have_current_path(idv_phone_path) | ||
|
|
||
| phone_field = find_field(t('two_factor_authentication.phone_label')) |
Contributor
Author
There was a problem hiding this comment.
Chromedriver was failing with an 'outdated element' explosion. Tracked down, and re-finding the field fixed it. No idea why it ever worked.
jmhooper
approved these changes
Nov 22, 2023
matthinz
approved these changes
Nov 22, 2023
solipet
approved these changes
Nov 22, 2023
jmax-gsa
deleted the
jmax/LG-11533-read-pii-from-session-for-account-presenter
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11533
🛠 Summary of changes
Updated
accounts_controller#showto explicitly pass the correct profile in toPii::Cacher#fetch## 📜 Testing Plan
Provide a checklist of steps to confirm the changes.
pii fetchingin the filespec/controllers/accounts_controller_spec.rb