Update Quibble dependency for latest Node.js 18.x, 20.x support#9720
Merged
Update Quibble dependency for latest Node.js 18.x, 20.x support#9720
Conversation
Force rebuild
This reverts commit 891eb21.
changelog: Internal, Dependencies, Update dependencies for latest Node.js compatibility
Contributor
Author
|
Verified that the tests failed (as expected) in the GitLab build before updating |
zachmargolis
approved these changes
Dec 6, 2023
charleyf
approved these changes
Dec 6, 2023
Contributor
charleyf
left a comment
There was a problem hiding this comment.
Confirmed that this fixed a problem we were having running tests.
This gives a quibble error
git pull
git checkout main
yarn install
yarn run mocha spec/javascript/packs/state-guidance-spec.js
This works
git pull
git checkout aduth-quibble
yarn install
yarn run mocha spec/javascript/packs/state-guidance-spec.js
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
quibbledependency to the latest version.Under the hood,
quibbleuses an experimental Node.js API (module loader hooks), which is subject to change in minor versions. This has happened, and our current version ofquibblewill fail to run on the latest version of Node.js v18.x. Since our.nvmrcspecifies only the top-level version, there's a good chance this could cause failures if a developer (i.e. me) runsnvm install && nvm useto use the latest valid version for the project. It's also expected this would start triggering failures in build if our GitLab CI were updated to use a new built image for CI.Relates to (effectively cherry-picks from): #9639
📜 Testing Plan
nvm install && nvm useyarn test