Skip to content

Update Quibble dependency for latest Node.js 18.x, 20.x support#9720

Merged
aduth merged 5 commits intomainfrom
aduth-quibble
Dec 6, 2023
Merged

Update Quibble dependency for latest Node.js 18.x, 20.x support#9720
aduth merged 5 commits intomainfrom
aduth-quibble

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 6, 2023

🛠 Summary of changes

Updates quibble dependency to the latest version.

Under the hood, quibble uses an experimental Node.js API (module loader hooks), which is subject to change in minor versions. This has happened, and our current version of quibble will fail to run on the latest version of Node.js v18.x. Since our .nvmrc specifies only the top-level version, there's a good chance this could cause failures if a developer (i.e. me) runs nvm install && nvm use to use the latest valid version for the project. It's also expected this would start triggering failures in build if our GitLab CI were updated to use a new built image for CI.

Relates to (effectively cherry-picks from): #9639

📜 Testing Plan

  1. Observe build passes
  2. Install latest version of Node.js and verify tests run successfully
    1. nvm install && nvm use
    2. yarn test

@aduth
Copy link
Contributor Author

aduth commented Dec 6, 2023

Verified that the tests failed (as expected) in the GitLab build before updating quibble (994f325) and after using a rebuilt GitLab image (4ed4bdf).

@aduth aduth marked this pull request as ready for review December 6, 2023 21:12
Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixed a problem we were having running tests.

This gives a quibble error

git pull
git checkout main
yarn install
yarn run mocha spec/javascript/packs/state-guidance-spec.js

This works

git pull
git checkout aduth-quibble
yarn install
yarn run mocha spec/javascript/packs/state-guidance-spec.js

@aduth aduth merged commit 18e907c into main Dec 6, 2023
@aduth aduth deleted the aduth-quibble branch December 6, 2023 22:33
@jmhooper jmhooper mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants