Skip to content

Allow in person flow to be repeated after resubmitting earlier step#9721

Merged
soniaconnolly merged 2 commits intomainfrom
sonia-gina-fix-in-person-flow-back-button-issue
Dec 6, 2023
Merged

Allow in person flow to be repeated after resubmitting earlier step#9721
soniaconnolly merged 2 commits intomainfrom
sonia-gina-fix-in-person-flow-back-button-issue

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Dec 6, 2023

🛠 Summary of changes

This is a bug-fix followup to back button work. Mark in person FSM steps incomplete when restarting the flow. Without this fix the in person FSM steps are marked complete the first time they are submitted and cannot be reentered.

📜 Testing Plan

Try this on main to confirm the bug, and then on this branch.

  • Create account, start Idv
  • Choose in person flow and submit the State Id page (optionally continue and submit Ssn)
  • Click back button back to Agreement step (or enter /verify/agreement url)
  • Resubmit Agreement and try to repeat in person flow
  • On main, you will jump to Ssn (or get a redirect loop if you submitted it)
  • On this branch, you will be able to complete the in person flow

soniaconnolly and others added 2 commits December 6, 2023 12:57
Otherwise they cannot be re-entered

Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
changelog: Bug Fixes, Identity verification in person back button, allow in person flow to be repeated after backing up and resubmitting an earlier step
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - demonstrated on main and confirmed fix on branch

@soniaconnolly soniaconnolly merged commit 8d3fe19 into main Dec 6, 2023
@soniaconnolly soniaconnolly deleted the sonia-gina-fix-in-person-flow-back-button-issue branch December 6, 2023 22:15
@jmhooper jmhooper mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants