Merged
Conversation
changelog: Internal, Automated Testing, Improve effectiveness of spec JSDOM reset
aduth
commented
Dec 11, 2023
| document.body.removeChild(document.body.firstChild); | ||
| for (const element of [document.head, document.body]) { | ||
| while (element.firstChild) { | ||
| element.firstChild.remove(); |
Contributor
Author
There was a problem hiding this comment.
Element#remove wasn't supported in IE11 which is why you see parent.removeChild(child) in a lot of sample snippets. We shouldn't need to worry about that compatibility in the context of specs, since JSDOM supports Element#remove.
mitchellhenke
approved these changes
Dec 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates JavaScript specs to more effectively reset the simulated DOM between test cases:
<head>as well as those in<body>reconfigurehelperThis is extracted from #9674 (0ae5baa76e8e4eb08e82d95e1918c0d8fe4ed30b), where it was observed that:
request/index.spec.tswas leaking across tests in how it manipulated<head>elementsreconfigurecan be a handy way to change the current URL in a spec (example)📜 Testing Plan
JavaScript tests should pass:
yarn test