LG-5873: Allow users to sign back into the SP with original browser after error#9692
Merged
LG-5873: Allow users to sign back into the SP with original browser after error#9692
Conversation
…aded for the user
mdiarra3
commented
Dec 4, 2023
|
|
||
| if warden.authenticated?(scope) && options[:store] != false | ||
| if record.unique_session_id != current_session_id | ||
| service_provider = warden.raw_session.dig('sp') |
Contributor
Author
There was a problem hiding this comment.
This will maintain the SP for the user when theyre redirected back to the Error page.
aduth
reviewed
Dec 5, 2023
kevinsmaster5
approved these changes
Dec 5, 2023
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good and works as tested locally.
aduth
approved these changes
Dec 6, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Tested and works as expected, LGTM 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-5873: sign in sp bug
🛠 Summary of changes
This puts back the SP sesson when we log out to maintain that as the user gets redirected to the sign in page again to reduce confusion