Merged
Conversation
nprimak
approved these changes
Dec 6, 2023
Contributor
nprimak
left a comment
nprimak
left a comment
There was a problem hiding this comment.
That does look much better, nice!
zachmargolis
approved these changes
Dec 6, 2023
Contributor
There was a problem hiding this comment.
you can do Time.zone.today to get around this rubocop
Suggested change
| ['Report Generated', Date.today.to_s], # rubocop:disable Rails/Date | |
| ['Report Generated', Time.zone.today.to_s], |
Contributor
Author
There was a problem hiding this comment.
oh sure! i was just keeping it consistent with what you'd used in the idv report, as i figured there had probably been a reason for it! happy to just update it to Time.zone.today -- i will also update the other reports to make it consistent.
Contributor
There was a problem hiding this comment.
LOL I think that was because those reports were loaded from the command line and didn't have Rails set, so Time.zone was nil. Inside this background job will always be Rails so it's fine
Contributor
There was a problem hiding this comment.
ditto
Suggested change
| let(:date) { Date.today.to_s } # rubocop:disable Rails/Date | |
| let(:date) { Time.zone.today.to_s } |
Sgtpluck
force-pushed
the
dmm/LG-11738/fix-sp-user-count-report
branch
from
012d8c1 to
7eb3a7c
Compare
Sgtpluck
force-pushed
the
dmm/LG-11738/fix-sp-user-count-report
branch
from
7eb3a7c to
6fe997f
Compare
Sgtpluck
force-pushed
the
dmm/LG-11738/fix-sp-user-count-report
branch
from
6fe997f to
d261cb7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11738
🛠 Summary of changes
Updates sp user count report to use the table report format
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: