LG 11453 Remove platform device nickname

[kevinsmaster5]

🎫 Ticket

LG-11453

🛠 Summary of changes

On Platform authenticator setup Nickname field is now a hidden field with the decorated device browser name as its value.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Go to http://localhost:3000
• Create a new account and add Face or touch unlock
• Note the absence of a nickname field. See that browser info is in the device nickname box.
• In some edge cases a user might have another device with the same OS and browser. Changes should allow for that. Testing can be done by way of modifying a user in the rails console

User.find_with_email('//user email//').webauthn_configurations.create(name: "//browser nice_name//", platform_authenticator: true, transports: ["internal", "hybrid"], credential_id: "123xyz", credential_public_key: "pdq456")

For browser nice name use the name that would be injected from your testing system like 'Chrome 120 on macOS 10'

Nickname field should still be present when adding a security key

Incremented number after the automatically generated nickname for duplicate device environment.

[mitchellhenke]

Is it possible to pass in the device name from the constructor? I think it'd be preferable since the device name from the user agent would be more direct compared to querying the database (and also saves a database query).

Is there concern that the existing unique requirement on name could create issues if it can't be overridden?

[kevinsmaster5]

Thanks for that suggestion. I'm still reworking how best to handle that but I'm no longer hitting recent_devices.

There is a method in WebauthnSetupForm that checks if the name is unique. I can try to handle appending to a duplicate name there.

[mitchellhenke]

I think it will need to be handled, yeah

[zachmargolis]

1. Ruby has no ++ operator (source link)

2. Since we're re-assigning @name this would have like "My Device (1) (2) (3)"

I would also consider counting the number of devices that exist and just appending? We can do a prefix match on the name to see how many of that device already exist

Suggested change

	incrementer = 1
	while WebauthnConfiguration.exists?(user_id: @user.id, name: @name)
	@name = "#{@name} (#{++incrementer})"
	end
	if WebauthnConfiguration.exists?(user_id: @user.id, name: @name)
	num_existing_devices = WebauthnConfiguration.
	where(user_id: @user.id).
	where('name LIKE ?', "#{@name}%").
	count
	@name = "#{@name} (#{num_existing_devices + 1})"
	end

[kevinsmaster5]

@zachmargolis thank you for that! It was starting with (2) when I tested locally, if I remove the + 1 that should start with (1) and go up from there, right?

[zachmargolis]

Yup! It's very naive, so for example if a user has "Device", "Device 1", "Device 2" and deletes "Device 1", the next would probably be "Device 2"? it might be fine?

[aduth]

Tested this locally and it worked as I expected, both in terms of generating the expected automatic nickname, as well as adding an incrementing suffix (I tested with 3 of the same generated name).

Added a comment about a previous review nitpick, but otherwise LGTM 👍