Conversation
* redirect in-person to personal key after gpo * change in_person to check user enrollment * add changelog changelog: Bug Fixes, IdV Personal Key, allow users to visit personal key page before in-person proofing * linty mclinterson * fix spec on gpo * moved account verified event to inside block * fix specs for gpo activation
LG-9966 * Added code to send email on GPO letter enqueue * Refactoring: Pulled common code out to User * Added email sent checks to GpoController and ReviewController specs Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> changelog: User-Facing Improvements,Verify by mail,Send an email on initial GPO letter request
* changelog: User-Facing Improvements, Authentication, Remove priority a/b testing and do auth app priority first * clean up more mfa priority test bucket * rubocop * fix up two factor presenter tests * remove unneeded mentions * add space * remove whitespace
#8561) * [skip changelog] * Define active on password_reset profile factory * Mark failing specs * Password reset profiles are never active * Unmark specs * Password reset profile is not verified. * Replace password_reset profile with verified profile in user spec * Remove `activated_at` from password reset profile factory known breakage: `spec/controllers/users/verify_personal_key_controller_spec.rb` * Use correct definition of password reset profile * Revert "Use correct definition of password reset profile" This reverts commit 8e472a3. * Specify verified explicitly as trait in password reset factory usages
* update H1 and button for gpo request page * changelog: User-Facing Improvements, Identity Verification, Update header and button on page for requesting a letter for address verification * remove test for resend letter title * fix test to verify letter request update * only initial letter request language should be changed * udpate title to verify * revert resend letter titling * re-add test for resending letter titling
* LG-9928: Implement User suspend and reinstate methods [skip changelog] * feedback
* Move GPO routes under /verify - Move GPO routes previously under /account to /verify - Add redirects for old paths changelog: Internal, GPO, Move GPO paths under /verify * Fix GPO presenter spec * Add specs for redirects
…#8585) * add same_address_as_id to verify visited analytics * mark in person verify info set as complete * changelog: Interal, In-person proofing, Add same_address_as_id to in person verify visited analytics * Moved setting value on flow session to verify info concern * Update app/controllers/concerns/idv/verify_info_concern.rb Updated comment to include more detail for following line of code Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * Modified how I was accessing data for readability Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> --------- Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
changelog: Internal, Logging, Send worker logs to STDOUT if configured to log to STDOUT
* remove route to 404 pg * remove refs to maybe redirect to verify info * lint fixes * add back in helper as it should be removed in another pr * remove line * lint issues * fix spacing * new line
This reverts commit 0a456fb5a60562a2a80b01dd4d5b8fda52e3686b.
#8582) * LG-9952 Welcome back screen should have a new information alert banner changelog: User-Facing Improvements, Identity Verification, Welcome back page for GPO letter displays banner containing recipient address * happy linting * keep french language consistent * only show address if pii exists * add tests for gpo verify alert content * verify adderess partial is rendered * happy linting * remove guard for pii * fix typo
…ctivated (#8549) * refactor ProfileMaker#save_profile * resolve profile_maker specs * remove active param from save_profile call [skip changelog] * handle exception if user fails to activate * happy linting * define verified_at right before save * rename exception to error * restore verified_at setting changed in PR #8405 * only activate unless there are reasons not to * typo fix * rename to reason_not_activate * verified_at should not set until active * update tests for verified_at to not be set before activaton * remove uneeded return use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * remove uneeded return use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * refactor confirm_that_profile_can_be_activated --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Give each verify_info_controller its own update method Keep shared code in VerifyInfoConcern#shared_update. [skip changelog] * Move final redirects into individual update methods * Only mark InPerson::VerifyStep complete in InPerson::VerifyInfoController * Move redo_document_capture check to doc_auth VerifyInfoController The in_person flow does not use redo_document_capture * Remove empty verify_info/new template accidentally added back in Jan. --------- Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
aduth
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal