Skip to content

Comments

LG-9972: Implement Usability priority#8560

Merged
mdiarra3 merged 9 commits intomainfrom
LG-9972-implement-mfa-ab-testing
Jun 13, 2023
Merged

LG-9972: Implement Usability priority#8560
mdiarra3 merged 9 commits intomainfrom
LG-9972-implement-mfa-ab-testing

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Jun 8, 2023

🎫 Ticket

LG-9972: Implement usability priority

👀 Screenshots

Screen Shot 2023-06-08 at 4 05 41 PM

@mdiarra3 mdiarra3 requested a review from a team June 8, 2023 20:06
@mdiarra3 mdiarra3 marked this pull request as ready for review June 12, 2023 14:41
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be a couple other lingering references

def sign_up_mfa_selection_order_bucket
return unless in_multi_mfa_selection_flow?
@sign_up_mfa_selection_order_bucket = AbTests::SIGN_UP_MFA_SELECTION.bucket(current_user.uuid)
end

def sign_up_mfa_selection_order_bucket
return unless in_multi_mfa_selection_flow?
AbTests::SIGN_UP_MFA_SELECTION.bucket(current_user.uuid)
end

@mdiarra3 mdiarra3 requested a review from aduth June 13, 2023 14:16
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdiarra3 mdiarra3 merged commit efe1ef9 into main Jun 13, 2023
@mdiarra3 mdiarra3 deleted the LG-9972-implement-mfa-ab-testing branch June 13, 2023 18:22
@jmhooper jmhooper mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants