LG-9536 stop writing to "deactivation_reason" for gpo_verification_pending#8405
Merged
LG-9536 stop writing to "deactivation_reason" for gpo_verification_pending#8405
Conversation
changelog: Internal, IdV GPO, remove gpo_verification_pending deactivation_reason
Contributor
|
fysa @olatifflexion about this column potentially going away |
app/models/profile.rb
Outdated
| password_reset: 1, | ||
| encryption_error: 2, | ||
| gpo_verification_pending: 3, | ||
| # gpo_verification_pending used to be here. Do not map anything to 3 for deactivation_reason |
Contributor
There was a problem hiding this comment.
one idea would be to rename it, instead of commenting out?
Suggested change
| # gpo_verification_pending used to be here. Do not map anything to 3 for deactivation_reason | |
| gpo_verification_pending__NO_LONGER_USED: 3, # deprecated |
matthinz
reviewed
May 16, 2023
eric-gade
approved these changes
May 18, 2023
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
On small inline comment/question, but otherwise LGTM
| success: true, | ||
| fraud_review_pending: idv_session.profile.fraud_review_pending?, | ||
| fraud_rejection: idv_session.profile.fraud_rejection?, | ||
| gpo_verification_pending: idv_session.profile.gpo_verification_pending?, |
Contributor
There was a problem hiding this comment.
Are we checking idv_session.profile.gpo_verification_pending? in some places and current_user.gpo_verification_pending_profile? in others because the information hasn't yet been put into the session (for the latter case)?
Contributor
Author
There was a problem hiding this comment.
Here we check idv_session because the profile was just created a few lines up. In other places we check current user because they may be in a new session where the data isn't persisted.
amirbey
added a commit
that referenced
this pull request
Jun 14, 2023
amirbey
added a commit
that referenced
this pull request
Jun 14, 2023
…ctivated (#8549) * refactor ProfileMaker#save_profile * resolve profile_maker specs * remove active param from save_profile call [skip changelog] * handle exception if user fails to activate * happy linting * define verified_at right before save * rename exception to error * restore verified_at setting changed in PR #8405 * only activate unless there are reasons not to * typo fix * rename to reason_not_activate * verified_at should not set until active * update tests for verified_at to not be set before activaton * remove uneeded return use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * remove uneeded return use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * refactor confirm_that_profile_can_be_activated --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9536Link to the relevant ticket.
🛠 Summary of changes
Removes the old
gpo_verification_pendingdeactivation_reason. We now read from thegpo_verification_pending_attimestamp. A roll plan has already occured to move users from the old deactivation reason to the new timestamps.