LG-9838: Move GPO routes under /verify#8586
Merged
Conversation
- Move GPO routes previously under /account to /verify - Add redirects for old paths changelog: Internal, GPO, Move GPO paths under /verify
Comment on lines
+408
to
+410
| # deprecated routes | ||
| get '/confirmations' => 'personal_key#show' | ||
| post '/confirmations' => 'personal_key#update' |
Contributor
There was a problem hiding this comment.
Tangential to this PR, can we delete these? When/how can we tell they're ready for deletion? I keep eyeing them.
I'll pull this down and try it tomorrow.
eric-gade
approved these changes
Jun 13, 2023
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
One question but otherwise looks good
soniaconnolly
approved these changes
Jun 13, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, works as described.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9838
🛠 Summary of changes
Moves a few GPO-related routes to be under
/verify(like the rest of the IdV code).📜 Testing Plan
Provide a checklist of steps to confirm the changes.
/verify/by_mailto enter your OTP./account/verifyand confirm you end up redirected to/verify/by_mail/verify/by_mail/confirm_start_over