Skip to content

Comments

LG-9966 send email on gpo letter enqueue#8580

Merged
jmax-gsa merged 5 commits intomainfrom
jmax/LG-9966-send-email-on-gpo-letter-enqueue
Jun 13, 2023
Merged

LG-9966 send email on gpo letter enqueue#8580
jmax-gsa merged 5 commits intomainfrom
jmax/LG-9966-send-email-on-gpo-letter-enqueue

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Jun 12, 2023

🎫 Ticket

LG-9966

🛠 Summary of changes

Added code to ReviewController to send reminder email on initial enqueue of GPO letter.

Also refactored a bit; there's now a User method to send an arbitrary email to all of a user's email addresses.
ToDo: Open a ticket to see where else we can use that method.

📜 Testing Plan

  • Create an account and proceed through GPO proofing
  • Verify that when you ask for a letter, an email notification is sent to you.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After: ![your-letter-is-coming-screen](https://github.com/18F/identity-idp/assets/101212334/d2b050df-233f-48c8-adfd-68ad846cbbe5)

your-letter-is-coming-email

Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Gitlab is asking for a changelog and some linting. (ETA: probably because it's still a draft, I just noticed!)

jmax-gsa and others added 3 commits June 13, 2023 11:35
Spec and first (really ugly) implementation
To be refactored; pushed for CI run
When user enqueue a GPO letter

Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
@jmax-gsa jmax-gsa force-pushed the jmax/LG-9966-send-email-on-gpo-letter-enqueue branch from c8aed51 to f53cd03 Compare June 13, 2023 15:35
jmax-gsa added 2 commits June 13, 2023 12:05
changelog: User-Facing Improvements,Verify by mail,Send an email on initial GPO letter request
@jmax-gsa jmax-gsa marked this pull request as ready for review June 13, 2023 16:37
@jmax-gsa jmax-gsa merged commit ac1bff2 into main Jun 13, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-9966-send-email-on-gpo-letter-enqueue branch June 13, 2023 16:52
@jmhooper jmhooper mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants