Conversation
| module Actions | ||
| module InPerson | ||
| class CancelUpdateAddressAction < Idv::Steps::DocAuthBaseStep | ||
| include Idv::Steps::TempMaybeRedirectToVerifyInfoHelper |
There was a problem hiding this comment.
@soniaconnolly should this be removed in conjunction with the removal of the 404 before action?
There was a problem hiding this comment.
No, it looks like you don't want to delete this until the final PR that deletes the feature flag. If then. Looks like it's managing when a step redirects to the in person VerifyInfoController. I would make a separate PR to replace this with a before_action or similar mechanism once the in person VerifyInfoController is completely live in production, after the feature flag is deleted.
There was a problem hiding this comment.
ok, I'll leave this removal out of this pr then
|
@svalexander I think your code changes are good. We just need to solidify our process to know when we want to merge this into main (or another env for testing)- and how/when this will get promoted. |
There was a problem hiding this comment.
LGTM - I would pull in main and make sure branch is up to date before merging
UPDATE 06-12-23 @svalexander I found some bugs with analytics. Please wait to merge this PR. I will give you a green light when we are ready! Thanks
svalexander
changed the title
3 participants
🎫 Ticket
LG-9866
🛠 Summary of changes
Remove 404 before action for verify info page.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
/verify(the verify info page) change url to/verify_info