Merged
Conversation
changelog: Bug Fixes, IdV Personal Key, allow users to visit personal key page before in-person proofing
jmax-gsa
reviewed
Jun 12, 2023
spec/features/idv/in_person_spec.rb
Outdated
| # personal key | ||
| expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.secure_account')) | ||
| expect(page).to have_content(t('titles.idv.personal_key')) | ||
| deadline = nil |
Contributor
There was a problem hiding this comment.
It doesn't look like we do anything with deadline. Did I miss a usage, or do we need another spec here, or what?
Contributor
Author
There was a problem hiding this comment.
yep. i'll remove it. it is not needed for this test
| end | ||
|
|
||
| def prepare_for_personal_key | ||
| event, _disavowal_token = create_user_event(:account_verified) |
Contributor
There was a problem hiding this comment.
Two questions that might be unhelpful:
- Do we need to destructure
_disavowal_tokensince we don't use it? - I'm not super familiar with
create_user_event, but are there side effects to calling it? The previous code used to completely skip this during IPP, so I just want to make sure nothing unexpected happens.
Otherwise this looks good!
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll move that line into the unless statement below. The alert is for people who pass verify-by-mail, but don't have a pending in-person step afterwards.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10024
🛠 Summary of changes
People were undergoing verify-by mail and In-Person Proofing were not reaching the Personal Key page. We changed how the redirect works.