Conversation
known breakage: `spec/controllers/users/verify_personal_key_controller_spec.rb`
This reverts commit 8e472a3.
jmhooper
approved these changes
Jun 13, 2023
theabrad
approved these changes
Jun 13, 2023
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM. This is a better way of splitting out the two states
kbighorse
commented
Jun 13, 2023
|
|
||
| trait :verified do | ||
| verified_at { Time.zone.now } | ||
| activated_at { Time.zone.now } |
Contributor
Author
There was a problem hiding this comment.
verified profiles have been activated (not necessarily active though)
kbighorse
commented
Jun 13, 2023
| trait :password_reset do | ||
| activated_at { Time.zone.now } | ||
| verified_at { Time.zone.now } | ||
| active { false } |
Contributor
Author
There was a problem hiding this comment.
password reset profiles are always not active
kbighorse
commented
Jun 13, 2023
| @@ -675,10 +676,10 @@ | |||
| end | |||
|
|
|||
| context 'the user has no active profile but has a previously verified profile' do | |||
Contributor
Author
There was a problem hiding this comment.
this test only needed a verified profile, not necessarily a password reset profile
kbighorse
changed the title
kbighorse
deleted the
LG-9987-specify-active-on-password-reset-profile-factory
branch
kbighorse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
password_reset Profile factory should only define password_reset, and also accommodate verified and not-verified variations
Also related to:
IDP must have a characterization test for profile states
🛠 Summary of changes
Previously, the
password_resettrait represented password reset profiles which were designed to only be possible for verified profiles. This change makes it possible to also represent password reset profiles that are not yet verified, or any other password reset profile.📜 Testing Plan