Conversation
amirbey
commented
Jun 7, 2023
amirbey
changed the title
amirbey
commented
Jun 8, 2023
Contributor
Author
|
Slightly tangential question: should we touch verified_at every time a profile is activated? should verified_at only be touched if doesn't already exist? 🤔 |
amirbey
force-pushed
the
amirbey/LG-9981-profile-maker-save-profile-confirm
branch
from
f647476 to
0352879
Compare
zachmargolis
reviewed
Jun 8, 2023
zachmargolis
reviewed
Jun 8, 2023
amirbey
force-pushed
the
amirbey/LG-9981-profile-maker-save-profile-confirm
branch
from
85e2081 to
3a32ae2
Compare
[skip changelog]
use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
use implicit return Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
amirbey
force-pushed
the
amirbey/LG-9981-profile-maker-save-profile-confirm
branch
from
3a32ae2 to
4c70e79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9981
🛠 Summary of changes
ProfileMaker#save_profileno longer activates the profile and only saves the profile; and now.IDV::Session#create_profile_from_applicant_with_passwordcreates the profile usingProfileMaker#save_profileand which is then activated based onProfile#confirm_that_profile_can_be_activated!.