Conversation
Keep shared code in VerifyInfoConcern#shared_update. [skip changelog] Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
The in_person flow does not use redo_document_capture
|
✅ Run through testing plan locally |
|
|
||
| if success | ||
| # Don't allow the user to go back to document capture after verifying | ||
| if flow_session['redo_document_capture'] |
There was a problem hiding this comment.
@soniaconnolly I'm pretty sure this isn't an issue for IPP, but how did your team encounter this behavior? I just want to make sure we don't also need this code.
There was a problem hiding this comment.
See LG-9996 and slack thread. VerifyInfo shows the user the option to redo document capture if they had a barcode read error. The code that lets the user redo is in the in_person verify_info show template, but I think it can be removed, since people can't get to the in person flow unless their ID couldn't be scanned.
There was a problem hiding this comment.
Yeah, I agree that that code can be deleted from the in_person verify_info show template. The @had_barcode_read_failure is not set in our controller. I can open a separate ticket for that work.
Thanks for flagging this!
|
|
||
| if success | ||
| # Don't allow the user to go back to document capture after verifying | ||
| if flow_session['redo_document_capture'] |
There was a problem hiding this comment.
Yeah, I agree that that code can be deleted from the in_person verify_info show template. The @had_barcode_read_failure is not set in our controller. I can open a separate ticket for that work.
Thanks for flagging this!
3 participants
For the deployment of InPerson::VerifyInfoController, in PR #8585 the InPerson::VerifyStep was marked complete at the end of VerifyInfoConcern#update. This method is shared with doc_auth VerifyInfoController. To eliminate the possibility of unintended effects, and to clarify #update for both controllers, give them each their own update method and rename the method in VerifyInfoConcern to shared_update.
In #8576 we recently added code to the shared update method that prevents redoing document capture after VerifyInfo is submitted. This does not apply to InPerson::VerifyInfoController, so this code was moved to the doc_auth VerifyInfoController#update.
📜 Testing Plan