Skip to content

Comments

LG-9952 Welcome back screen should have a new information alert banner#8582

Merged
amirbey merged 9 commits intomainfrom
amirbey/LG-9952-update-gpo-welcome-back
Jun 14, 2023
Merged

LG-9952 Welcome back screen should have a new information alert banner#8582
amirbey merged 9 commits intomainfrom
amirbey/LG-9952-update-gpo-welcome-back

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Jun 12, 2023

🎫 Ticket

LG-9952

🛠 Summary of changes

Add a banner to the welcome back page for gpo letter verification that lets the user

  1. know the address their letter was sent
  2. opt to cancel idv and start over within the banner.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through the Idv process and request a GPO letter
  • Visit example.com/accounts/verify and verify banner

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before: Screen Shot 2023-06-12 at 3 33 30 PM Screen Shot 2023-06-12 at 3 33 44 PM Screen Shot 2023-06-12 at 3 33 54 PM
After: Screen Shot 2023-06-13 at 12 55 57 PM Screen Shot 2023-06-12 at 3 02 57 PM Screen Shot 2023-06-12 at 3 03 14 PM

@amirbey amirbey self-assigned this Jun 12, 2023
@amirbey amirbey force-pushed the amirbey/LG-9952-update-gpo-welcome-back branch from a42f99d to 0dc395e Compare June 12, 2023 20:04
@amirbey amirbey marked this pull request as ready for review June 12, 2023 22:10
@amirbey amirbey requested a review from a team June 12, 2023 22:11
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Could we consider adding spec coverage for (a) the content existing as expected and (b) the link in the alert clearing & starting over ?

@amirbey amirbey force-pushed the amirbey/LG-9952-update-gpo-welcome-back branch from 1d2a990 to 7631fd5 Compare June 14, 2023 15:11
@amirbey amirbey merged commit 64d67ce into main Jun 14, 2023
@amirbey amirbey deleted the amirbey/LG-9952-update-gpo-welcome-back branch June 14, 2023 15:38
@jmhooper jmhooper mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants