Skip to content

Deploy RC 268 to Production#8119

Merged
mitchellhenke merged 26 commits intostages/prodfrom
stages/rc-2023-04-03
Apr 3, 2023
Merged

Deploy RC 268 to Production#8119
mitchellhenke merged 26 commits intostages/prodfrom
stages/rc-2023-04-03

Conversation

@mitchellhenke
Copy link
Contributor

User-Facing Improvements

  • Content Update: Updating (#8097)
  • Identity Verification: Update link in "You verified your identity" email for password reset (#8109)
  • Identity Verification Language Update: Update language (#8102)
  • State id page: Add transliteration validation to address input fields (#8099)
  • State id page: Add link to help center link (#8108)

Bug Fixes

  • Code Revert: Revert changes introduced in a534447 (#8091)
  • SAML Authentication: Validate SAML action path before rendering form (#8105)

Internal

  • Asset Compilation: Publish Sass compilation utility to NPM (#8111)
  • Attempts API: Batch Job improvements (#8114)
  • Attempts API: Remove events from Redis after background job completed (#8062)
  • Attempts API: Local development configs (#8064)
  • Authentication: Ensure more consistent incrementing of attempts (#8118)
  • Code Quality: Remove unreachable code (#8107)
  • Code Quality: Improve resiliency of logic for session timeout behaviors (#8117)
  • Flow State Machine replacement: Redirect to and from DocumentCaptureController (feature flagged) (#8090)
  • Fraud review: Update fraud review tasks to handle nil/missing data (#8096)
  • IdV GPO: Add verified_at when a user completes gpo (#8103)
  • IdV please call: Rename idv_setup_errors to (#8094)
  • Identity verification: Fix link to help center articles for identity verification phone finder step (#8086)
  • In-person proofing: Fix flakey proofing results job tests (#8081)
  • Session Timeout: Refactor session timeout request behaviors (#8092)

Upcoming Features

  • In-Person Proofing: Send USPS the state ID address instead of residential address based on a feature flag (#8098)

olatifflexion and others added 26 commits March 29, 2023 12:28
changelog: Internal, Attempts API, Remove events from Redis after background job completed
* Draft: Refactor of usps proofing job spec to eliminate flakey tests.

* Moved range checks to shared example

* changelog: Internal, In-person proofing, Fix flakey proofing results job tests

* whacking with linter

* Removing uneeded ranges

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Update spec/jobs/get_usps_proofing_results_job_spec.rb

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>

* Fix linting issue

* downcase an e so we capture the exception reason

---------

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
* Update users:review:pass task to handle nil/missing data (LG-9271)
* Update users:review:reject to handle nil/missing data

changelog: Internal, Fraud review, Update fraud review tasks to handle nil/missing data

---------

Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com>
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Sonia Connolly <soniaconnolly@users.noreply.github.com>
* Add Sessions API controller

[skip changelog]

* Rename "active" to "live"

Backward-compatibility, works just as well

* Namespace SessionsController as internal

See: https://github.com/18F/identity-idp/pull/8089/files#r1151141988
* Upgrade msw dependency

* Extract session timeout JavaScript package

Why:

1. Shared logic for common session API interaction
2. Better testability
3. Support upcoming work for session modal custom element as part of this package
4. Reduce scope of session-timeout-ping pack toward eventual removal

changelog: Internal, Session Timeout, Refactor session timeout request behaviors

* Rename package to identity-session

Shorter, more accommodating to additional features, reflects the existing description "utilities for managing a user's session"

* Rename requestSessionKeepAlive as extendSession

See: #8092 (comment)

* Map response live property to isLive

See: #8092 (comment)

* Hide package internal types from public API
* move setup errors to please call

* rename setup errors to please call

* rename setup_errors_controller_spec to please_call_controller_spec

* add changelog

changelog: Internal, IdV please call, Rename idv_setup_errors to
idv_please_call

* fix tests

* add redirect from old setup_errors route

* add previous event name for IdV: Verify please call
* Updating locales and view for Idv Welcome screen


Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

changelog: User-Facing Improvements, Content Update, Updating
information on the Idv Welcome Step screen
* Mark URL to be replaced

* Use correct help center article in phone form link

* Remove marker

changelog: Internal, Identity verification, Fix link to help center articles for identity verification phone finder step

* Replace references to obsolete phone number help center article

* Add link to help center phone article to phone error warning screen

* Add location field to options

Co-authored by @aduth

* Remove warning location option for non-warning screen
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>

changelog: User-Facing Improvements, Identity Verification Language Update, Update language
in Step Indicator
* Update learn more phone copy

* Update translations of new text

* [skip changelog]

* Update es.yml

* Update fr.yml

---------

Co-authored-by: Princess Ojiaku <princess.ojiaku@gsa.gov>
This reverts commit a534447.

changelog: Internal, Session Timeout, Remove redundant timeout value from session timeout API
changelog: Internal, IdV GPO, add verified_at when a user completes gpo
gpo verification
* add link and text

* use help center article link

* changelog: User-Facing Improvements, State id page, add link to help center link

* capitalize id
)

* Redirect to new document capture controller from ssn controller

If feature flag is set, redirect back to new controller instead of doc_auth_url.

* redirect to new controller in desktop flow

* add missing _ to analytics step name

changelog: Internal, Flow State Machine replacement, redirect to and from DocumentCaptureController (feature flagged)

* Redirect from document_capture controller to ssn step if session already has pii

* Conditionally redirect to document capture url from address step

* From address page, check for standard flow before redirecting

to DocumentCaptureController

* Add specs to check guards against redirecting to document_capture too early or late

And check if the VerifyInfo step is complete in confirm_document_capture_needed before action

Check in feature specs for ignoring redirects to completed steps

* Check for UploadStep complete rather than AgreementStep

* Add spec to test required earlier steps and test mobile only flow

* Update spec/controllers/idv/document_capture_controller_spec.rb

Capitalization change in spec.

* Readability changes

---------

Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Code Quality, Remove unreachable code
…id pg (#8099)

* add transliteration validation to additional fields on state id pg

* changelog: User-Facing Improvements, State id page, add transliteration validation to address input fields

* delete nontransliterable fields and add spec when dav is false

* remove binding pry and change deep_dup to dup
#8098)

* LG-8932: Send USPS the state ID address instead of residential address

changelog: Upcoming Features, In-Person Proofing, Send USPS the state ID address instead of residential address based on a feature flag

* LG-8932: Add same address as id check; minor refactoring; fix tests
changelog: Internal, Attempts API, Local development configs
…LG-9285) (#8109)

* "You verified your identity" email links to password reset (LG-9285)

changelog: User-Facing Improvements, Identity Verification, Update link in "You verified your identity" email for password reset

---------

Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Publish 18f/identity-build-sass@1.1.0 to NPM

changelog: Internal, Asset Compilation, Publish Sass compilation utility to NPM

* Update CHANGELOG.md

* Include extra file in publish
changelog: Internal, Code Quality, Improve resiliency of logic for session timeout behaviors
* Validate SAML action path before rendering form

changelog: Bug Fixes, SAML Authentication, Validate SAML action path before rendering form

* add failing spec

* enable saml internal post by default

* fix spec

* use early return if action not found
* LG-9146 Pick up missed files in Batch Job

changelog: Internal, Attempts API, Batch Job improvements

Co-authored-by: Matt Wagner <n1zyy@users.noreply.github.com>

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Update learn more phone copy

* Update translations of new text

* [skip changelog]

* Update es.yml

* Update fr.yml

* [skip changelog]

* Move location to url options

---------

Co-authored-by: Princess Ojiaku <princess.ojiaku@gsa.gov>
* Ensure more consistent incrementing of attempts

changelog: Internal, Authentication, Ensure more consistent incrementing of attempts

* Update app/models/user.rb

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Update app/models/user.rb

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

---------

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke mitchellhenke merged commit 34c0365 into stages/prod Apr 3, 2023
@mitchellhenke mitchellhenke deleted the stages/rc-2023-04-03 branch April 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.