LG-9099 LG-9100 Redirects to and from document capture controller#8090
Merged
soniaconnolly merged 12 commits intomainfrom Mar 31, 2023
Merged
Conversation
If feature flag is set, redirect back to new controller instead of doc_auth_url. Note: not checking for desktop/mobile/hybrid flow Co-authored-by: Doug Price <douglas.price>
Co-authored-by: Eric Gade <eric.gade@gsa.gov>
when feature flag is set
…m ssn step changelog: Internal, Flow State Machine replacement, redirect to and from DocumentCaptureController (feature flagged)
to DocumentCaptureController
… early or late And check if the VerifyInfo step is complete in confirm_document_capture_needed before action Check in feature specs for ignoring redirects to completed steps
soniaconnolly
force-pushed
the
sonia-lg-9099-redirects-to-and-from-document-capture-controller
branch
from
11d3731 to
0103dce
Compare
Co-authored-by: Eric Gade <eric.gade>
theabrad
approved these changes
Mar 31, 2023
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM. Followed the steps outlined and got the same results
zachmargolis
approved these changes
Mar 31, 2023
|
|
||
| flow_session&.delete('Idv::Steps::DocumentCaptureStep') | ||
| redirect_to idv_doc_auth_url | ||
| if (IdentityConfig.store.doc_auth_document_capture_controller_enabled && |
Contributor
There was a problem hiding this comment.
Could we pull out flow_path as a variable like we did in the other controller to shorten the line? Also drop the outer parens
Contributor
Author
There was a problem hiding this comment.
Sure, I can pull out flow_path. Planning to make more changes to that in a followup PR. Found an indentation that rubocop will accept that distinguishes between the 2-line condition and 1-line block, so removed parens.
Capitalization change in spec. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
soniaconnolly
deleted the
sonia-lg-9099-redirects-to-and-from-document-capture-controller
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9099
LG-9100
🛠 Summary of changes
When feature flag is enabled, in desktop flow only, automatically redirect to and from the new DocumentCaptureController for the Document Capture step. Added a test that confirms that mobile-only flow also works.
Notes:
📜 Testing Plan
doc_auth_document_capture_controller_enabledfeature flag totruein local application.yml/verify/document_capture(not/verify/doc_auth/document_capture)/verify/ssnand expect to land back on/verify/document_captureverify/addressand expect to land back on/verify/document_capture/verify/document_captureand expect to land back on/verify/ssn