Remove redundant "remaining" value from session timeout API (Part 2)#8091
Merged
Remove redundant "remaining" value from session timeout API (Part 2)#8091
Conversation
This reverts commit a534447. changelog: Internal, Session Timeout, Remove redundant timeout value from session timeout API
Contributor
Author
|
The dependent code is live in production as of RC 267, so this can now be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Follow-up to #8084
The work of #8084 was split to two separate changes to avoid issues during deployment. This should only be merged after #8084 is live in production.
📜 Testing Plan
rspec spec/controllers/users/sessions_controller_spec.rb