LG-9146 Pick up missed files in Batch Job#8114
Merged
ThatSpaceGuy merged 8 commits intomainfrom Apr 3, 2023
Merged
Conversation
changelog: Internal, Attempts API, Batch Job improvements
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
n1zyy
approved these changes
Apr 3, 2023
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I left a handful of really nitpicky comments around making tests clearer, some of which I'm guilty of helping you co-author.
However, I think that means the code itself is :chef-kiss:, so I'm slapping an approval on this and just leaving some minor suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts API, Batch Job improvements