Refactor of USPS proofing job spec to eliminate flakey tests#8081
Merged
JackRyan1989 merged 17 commits intomainfrom Mar 29, 2023
Merged
Refactor of USPS proofing job spec to eliminate flakey tests#8081JackRyan1989 merged 17 commits intomainfrom
JackRyan1989 merged 17 commits intomainfrom
Conversation
svalexander
reviewed
Mar 28, 2023
| issuer: pending_enrollment.issuer, | ||
| minutes_since_last_status_check: 15.0, | ||
| minutes_since_last_status_update: 2.days.in_minutes, | ||
| minutes_to_completion: range_approximating(3.days.in_minutes, vary_left: -60, vary_right: 5), |
Contributor
There was a problem hiding this comment.
i'm unfamiliar w/ vary_left and vary_right - are they the bounds of the range?
Contributor
Author
There was a problem hiding this comment.
Yep. So this line says to expect a value between a range going from 1 hour before 3.days.in_minutes to five minutes after that time.
tomas-nava
reviewed
Mar 29, 2023
JackRyan1989
changed the title
tomas-nava
reviewed
Mar 29, 2023
Contributor
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
approve!
I made a bunch of tiny suggestions of additional parameters to include; you can ignore them if they're redundant or irrelevant.
tomas-nava
approved these changes
Mar 29, 2023
eileen-nava
approved these changes
Mar 29, 2023
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Tests passed when I repeatedly ran them on my local machine. LGTM.
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of USPS Proofing job spec to hopefully eliminate flakey tests.
Changes:
freeze_timeblocks📜 Testing Plan
Provide a checklist of steps to confirm the changes.