Update fraud review rake tasks to handle nil data (LG-9271)#8096
Merged
zachmargolis merged 6 commits intomainfrom Mar 29, 2023
Merged
Update fraud review rake tasks to handle nil data (LG-9271)#8096zachmargolis merged 6 commits intomainfrom
zachmargolis merged 6 commits intomainfrom
Conversation
Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com>
Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com>
changelog: Internal, Fraud review, Update fraud review tasks to handle nil/missing data
soniaconnolly
approved these changes
Mar 29, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Lots of new tests, yay! LGTM overall, and also added a couple of comments.
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Sonia Connolly <soniaconnolly@users.noreply.github.com>
aduth
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Update users:review:pass task to handle nil/missing data (LG-9271) * Update users:review:reject to handle nil/missing data changelog: Internal, Fraud review, Update fraud review tasks to handle nil/missing data --------- Co-authored-by: Amir Reavis-Bey <amirbey@users.noreply.github.com> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Sonia Connolly <soniaconnolly@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9271
🛠 Summary of changes
STDOUTso that we canstub_constit