Merged
Conversation
Why: 1. Shared logic for common session API interaction 2. Better testability 3. Support upcoming work for session modal custom element as part of this package 4. Reduce scope of session-timeout-ping pack toward eventual removal changelog: Internal, Session Timeout, Refactor session timeout request behaviors
Shorter, more accommodating to additional features, reflects the existing description "utilities for managing a user's session"
zachmargolis
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This pull request extracts logic reused between
session-timeout-ping.tsanddocument-capture.tspacks related to session behavior to a new JavaScript package,@18f/identity-session.Rationale:
📜 Testing Plan
yarn mocha app/javascript/packages/session-timeout/index.spec.ts