Conversation
added 2 commits
March 29, 2023 14:22
changelog: User-Facing Improvements, Content Update, Updating information on the Idv Welcome Step screen
aduth
approved these changes
Mar 29, 2023
config/locales/doc_auth/en.yml
Outdated
Comment on lines
+204
to
+206
| text3_html: '<strong>Verify by phone</strong>: We’ll call or text your phone | ||
| number. This takes a few minutes.' | ||
| text4_html: '<strong>Verify by mail</strong>: We’ll mail a letter to your home |
Contributor
There was a problem hiding this comment.
I think the numbering here was meant to correspond to the bullet3 heading, so I might expect something like text3a and text3b instead of text3 and text4.
Elsewhere, I've seen a move away from enumerating strings like this and using arrays instead, since it avoids some of the common headaches with numbering manually. Not sure if it'd be a great fit here though.
Example:
identity-idp/app/views/idv/in_person/ready_to_verify/show.html.erb
Lines 78 to 80 in d387ce2
| <ul class="usa-list"> | ||
| <li><%= t('doc_auth.instructions.text3_html') %></li> | ||
| <li><%= t('doc_auth.instructions.text4_html') %></li> | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: Could close up the excess spacing here.
Suggested change
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9820
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
English:
Spanish:
French: