Remove code for unused no-SP registration heading#8107
Merged
Conversation
changelog: Internal, Code Quality, Remove unreachable code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-9216
🛠 Summary of changes
Removes unreachable code for account registration headings for users not associated with a service provider.
SessionDecorator#registration_headingvaries depending on whether there's an associated service provider, but this heading is only ever rendered in logic paths where a service provider exists. Thus, the changes here simplify to a single view for registrations associated with a service provider and removes unnecessary logic.There should be no user-facing impact of these changes.
📜 Testing Plan
For
app/views/devise/sessions/new.html.erb:For
app/views/users/authorization_confirmation/new.html.erb: See #5735 (comment)