Skip to content

Remove code for unused no-SP registration heading#8107

Merged
aduth merged 1 commit intomainfrom
aduth-rm-no-sp-registration-heading
Mar 31, 2023
Merged

Remove code for unused no-SP registration heading#8107
aduth merged 1 commit intomainfrom
aduth-rm-no-sp-registration-heading

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 31, 2023

🎫 Ticket

Supports LG-9216

🛠 Summary of changes

Removes unreachable code for account registration headings for users not associated with a service provider.

SessionDecorator#registration_heading varies depending on whether there's an associated service provider, but this heading is only ever rendered in logic paths where a service provider exists. Thus, the changes here simplify to a single view for registrations associated with a service provider and removes unnecessary logic.

There should be no user-facing impact of these changes.

📜 Testing Plan

For app/views/devise/sessions/new.html.erb:

  1. Start from sample application
  2. Click "Sign in"
  3. Observe heading "Example Sinatra App is using ..."

For app/views/users/authorization_confirmation/new.html.erb: See #5735 (comment)

changelog: Internal, Code Quality, Remove unreachable code
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit e4ada0e into main Mar 31, 2023
@aduth aduth deleted the aduth-rm-no-sp-registration-heading branch March 31, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants