LG-9229 add transliteration validation to additional fields on state id pg

[svalexander]

🎫 Ticket

LG-9229

🛠 Summary of changes

Add transliteration validation for address line 1, address line 2 and city.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Set in_person_capture_secondary_id_enabled to true
• Walk through ipp flow up to the state id page
• Enter inputs with non-transliterable characters and make sure error shows after clicking continue; examples:
  * for address lines #1 $treet lañe^ should identify $, ^ as characters that need to be replaced
  * for city line B3st C!ty should identify 3, ! as characters that need to be replaced

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

[allis-green]

Looks good to me!

[NavaTim]

I would be inclined to test with DAV both on/off until it's enabled in prod.

[NavaTim]

You will also need to redact some errors from the log, similar to this:
59c383d#diff-3b900ce50338ce0c9fafd805a3625ef6f1a1591749891fd1c97b65375fd02740

[NavaTim]

I removed several feedback items since the messaging makes sense & @allis-green approves. That leaves the log redaction (required) and the additional automated testing (recommended).

[aduth]

You will also need to redact some errors from the log, similar to this: 59c383d#diff-3b900ce50338ce0c9fafd805a3625ef6f1a1591749891fd1c97b65375fd02740

This feels like an easy thing to overlook and would have had bad consequences if not had you caught it. Perhaps separately, can we consider some options to try to catch this sooner, like changing errors to allowlist-only, or enhancing the FakeAnalytics PiiAlerter utility to catch these mock IPP values?

[NavaTim]

This feels like an easy thing to overlook and would have had bad consequences if not had you caught it. Perhaps separately, can we consider some options to try to catch this sooner, like changing errors to allowlist-only, or enhancing the FakeAnalytics PiiAlerter utility to catch these mock IPP values?

@aduth It makes sense to add some additional detection. I feel like our team could add a story to check for :nontransliterable_field in the PiiAlerter, but may want to discuss an allowlist w/ other teams before implementing that approach.

[svalexander]

You will also need to redact some errors from the log,
@NavaTim want to double check with you how to verify this is working as expected. I tried adding some print statements but cleaned errors is empty before the delete statements

[NavaTim]

Remove this debugging code.

Suggested change

# binding.pry

[NavaTim]

@svalexander I realized I made a mistake when originally working on this, and that's why FakeAnalytics didn't catch the issue here. This change will fix the issue.

Suggested change

	cleaned_errors = errors.deep_dup
	cleaned_errors = errors.dup

I'd appreciate if you make the same change to address_form.rb as well.

@aduth FYI I think this is part of the issue here, i.e. ActiveModel::Error supports dup for cloning, but not deep_dup. There may also be issues when trying to print out the contents of these error objects directly.