Merged
Conversation
* Adding doc auth rate triggered analytics call for acuant Co-authored-by Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by John Skinner <john.skinner@gsa.gov> changelog: Internal Improvements, Logging, adding missing logging information
… reflect nationwide capacity (#7682)
* corrected the form response used by doc_auth_submitted event. changelog: Internal, Attempts API, Event bugfix * updated specs to reflect function being moved. * linter fixes
changelog: Internal, Reporting, Add new cumulative registrations reporting
… State Machine (rebased) (#7676) * Add test for Continue from verify_info screen * Add scaffolding to remove verify_wait from flow state machine * Add more methods to make verify_info#update work * Update test to go to next step, now passes * New specs * Small ssn_step cleanup * throttle and continue spec passes * Separate kinds of throttles * Verify_info feature tests passing Redirect back to verify_info if needed from review controller before action * Create Concern for redact method per PR feedback. This is now available for a future PR to use in PhoneController and VerifyBaseStep. Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> changelog: Internal, Flow State Machine, Add update action for new VerifyInfoController
changelog: Internal, Browser Support, Remove fallback behavior for unsupported browsers
* Allow omission of payload in frontend analytics controller * Avoid default payload argument micro-optimization: transpilation of args defaulting is slightly verbose. also results in marginal reduction of size of payload over the wire (see spec changes) * Reference fetch on global micro-optimization: shave a few characters "window" * Refactor fetch call as then-able micro-optimization: avoid error variable and "try' statement; minified output is also better able to collapse the preceding "if" statement * Split PasswordToggle elements to getters - more aligned with standards vs. object of elements - less indirection, more direct access - avoid decorator premature optimization - micro-optim: avoid "elements" pass-through changelog: Internal, Performance, Reduce size of JavaScript bundles
* Migrate input fields to design system changelog: User-Facing Improvements, Forms, Use design system styling for all form inputs * Restore margin bottom on form wrapper * Convert ad hoc field to standard * Upgrade to identity-style-guide@6.7.0
changelog: Internal, Performance, Reduce size of JavaScript assets
* Remove a few redundant BassCSS styles changelog: Internal, Performance, Reduce size of stylesheet assets * Reset margin on verify <dl> elements
…de (#7685) changelog: Internal, Analytics, Move GPO and phone step log events to call sites
changelog: Internal, Performance, Only allow email parameter in sessions controller
* Replace database phone one-time password rate limiter with Redis changelog: Internal, Rate Limiting, Replace database phone one-time password rate limiter with Redis * Update app/services/otp_rate_limiter.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * format phone number * use redis throttle in test * allow dynamic throttle config when not in production * fix specs * testing * fix spec Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…fig (#7678) * Removing old Acuant SDK 11.7.0 files and updating default config * Updating tests to use latest Acuant SDK version * Adding test for configured vs available acuant sdk versions changelog: Internal Improvements, Acuant SDK, Removing old version
* usps ippaas enrollment created analytics event added to analytics_events * add analytics to enrollment_helper * add test for analytic event * changelog: Internal, Analytics Events, add analytics event for usps enrollment creation * pass user to analytics in enrollment helper * update user id to use uuid to follow convention * get issuer from enrollment * update test to check uuid * use issuer from enrollment for service_provider * remover user_id and dont pass sp to analytics * explicitly test for missing/present sp Co-authored-by: Tomas Apodaca <tomas@navapbc.com>
…ted (#7696) The upload step gets "submitted" regardless of whether or not it is actually visibile to the user (see the `update_if_skipping_upload` before action in the `DocAuthController`). This results in a submission event being logged regardless of whether the user actually submitted the step. This commit adds a param to the logs which will indicate to use that though there is a submission event the step was skipped an not visible to the user. This will be helpful in building a hybrid flow dashboard to determine how many users actually encounter the hybrid flow selection and what their choices are from that screen. [skip changelog]
* Add spinner button to verify_info_controller#show * Show error alerts when verify info is throttled * Add wait.html.erb in views/shared A separate PR will use this template from other code paths * Add controller specs for throttling Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> changelog: Internal, Flow State Machine, add spinner button to VerifyInfo path
…ds (#7699) * Use StringRedacter instead of redact method Move test from NewPhoneForm to new StringRedacter spec * Make redact_alphanumeric a static method per PR feedback * move string_redacter under services Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> [skip changelog]
* Initial commit of typescript conversion changelog: Internal, Refactoring, Refactor FileInput to TS
* Use shared wait.html.erb from PhoneController * Remove unused wait.html.erb in idv/gpo [skip changelog]
* display error alert component on front-end * display internal error when usps api times out * improve backend testing and logging * update logging * display error above page heading * get false positive on FE test changelog: Improvements, In-person proofing, display 500 error when USPS API throws an error * refactor FE testing for in-person-location-step & in-person-post-office-location-step * tests pass after context blocks change order * wrap AddressSearch in SWRConfig AddressSearch spec to fix diff test that uses AddressSearch component * install swr to workspace with yarn * Reinstall swr as a dev dependency * refactor in response to feedback * remove cruft from in-person-location-post-office-search spec Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
changelog: Internal, Attempts API, Fetch from Redis in batches
* changelog: Bug Fixes, In-Person Proofing, Do not eagerly reset foundAddress onSearch * Hide previous results when loading new locations * Add test case for bug * Move test to dedicated test spec
Contributor
|
Not sure if it matters much, but the branch name is missing the |
Contributor
aduth
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal