LG-7400 Add update functionality to VerifyInfoController outside Flow State Machine (rebased)#7676
Merged
soniaconnolly merged 14 commits intomainfrom Jan 23, 2023
Merged
LG-7400 Add update functionality to VerifyInfoController outside Flow State Machine (rebased)#7676soniaconnolly merged 14 commits intomainfrom
soniaconnolly merged 14 commits intomainfrom
Conversation
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Replace resolution_info_verified with already existing resolution_successful Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Look for proofing results in :stages, :resolution rather than :extra Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Redirect back to verify_info if needed from review controller before action Proofing results exception found deeper in data structure on failure Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
per PR feedback. This is now available for a future PR to use in PhoneController and VerifyBaseStep. Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov>
changelog: Internal, Flow State Machine, Add update action for new VerifyInfoController
6 tasks
eric-gade
approved these changes
Jan 23, 2023
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
manually compared with older branch, looks good
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the correct set of cherry-picked commits from PR #7661. Recommend merging this one instead. Feedback from prior reviews has been addressed.
What
Add update functionality to VerifyInfoController outside Flow State Machine
All changes are hidden behind doc_auth_verify_info_controller_enabled IdentityConfig feature flag which is false in prod.
🎫 Ticket
LG-7400
📜 Testing Plan
Provide a checklist of steps to confirm the changes.