Remove event-specific hooks in Analytics class, move up to calling code#7685
Merged
zachmargolis merged 3 commits intomainfrom Jan 24, 2023
Merged
Remove event-specific hooks in Analytics class, move up to calling code#7685zachmargolis merged 3 commits intomainfrom
zachmargolis merged 3 commits intomainfrom
Conversation
changelog: Internal, Analytics, Move GPO and phone step events to call sites
zachmargolis
commented
Jan 23, 2023
|
|
||
| def register_doc_auth_step_from_analytics_event(event, attributes) | ||
| return unless user && user.class != AnonymousUser | ||
| success = attributes.blank? || attributes[:success] == 'success' |
Contributor
Author
There was a problem hiding this comment.
in hindsight, very strange this code checked that :success == 'success' since I'd expect it to be true|false
aduth
approved these changes
Jan 24, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 I was also not a fan of docauth-specific code living in the base analytics class.
jskinne3
reviewed
Jan 24, 2023
| end | ||
|
|
||
| def register_doc_auth_step_from_analytics_event(event, attributes) | ||
| return unless user && user.class != AnonymousUser |
Contributor
There was a problem hiding this comment.
Is this check for AnonymousUser retained in the replacement code?
Contributor
Author
There was a problem hiding this comment.
it is not, but it would be extremely surprising if an anonymous (logged out) user was able to make it all the way through IDV, I figured it was not worth carrying over
Merged
zachmargolis
added a commit
that referenced
this pull request
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that we have moved all analytics events to methods (instead of string keys), we could explicitly call this specific side effects at the call sites, instead of guessing where they came from. It leaves us with cleaner code IMO
This should be a no-op in terms of log data