LG-7401 Add spinner button for VerifyInfoController#show#7686
LG-7401 Add spinner button for VerifyInfoController#show#7686soniaconnolly merged 5 commits intomainfrom
Conversation
Also adding the wait template Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> [skip changelog]
A separate PR will use this template from other code paths
changelog: Internal, Flow State Machine, add spinner button to VerifyInfo path
changelog: Internal, Flow State Machine, add spinner button to VerifyInfo path
| analytics.idv_doc_auth_verify_visited(**analytics_arguments) | ||
|
|
||
| redirect_to failure_url(:fail) and return if any_throttled? | ||
| redirect_to throttled_url and return if any_throttled? |
There was a problem hiding this comment.
Unless I am mistaken, we still need to add some throttle logic to either the update action or move this into a before action
There was a problem hiding this comment.
Thanks for catching that. I looked at adding a before action, noticed that we redirect to different error pages at different times because of throttles, and then got side tracked. Will follow up.
There was a problem hiding this comment.
On further looking at code, it looks like throughout the proofing flow, throttling doesn't get checked at the beginning of update/create actions. I wonder if we can address that as a bug separately from removing verify from FSM.
There was a problem hiding this comment.
Added a commit on a separate branch and we can decide if we want to pull it in to this branch. c5c474b
There was a problem hiding this comment.
I am totally fine with a different PR. We can open a bug ticket if we need. I do think we should fix it before deploying this.
There was a problem hiding this comment.
Opened a ticket. Checking that by "before deploying" you meant before LG-7402. I'd like to merge this for tomorrow because I have another branch that depends on it. https://cm-jira.usa.gov/browse/LG-8742
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
Approving with the understanding that we will address the throttle comment in a separate change request
3 participants
🎫 Ticket
LG-7401
🛠 Summary of changes
Add the spinner button to verify_info and tests for throttling by ssn and resolution.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.