Use design system styling consistently for form fields#7576
Merged
Conversation
mitchellhenke
approved these changes
Jan 4, 2023
zachmargolis
reviewed
Jan 4, 2023
aduth
force-pushed
the
aduth-design-system-field
branch
from
87ec76c to
765ae5b
Compare
aduth
force-pushed
the
aduth-design-system-field
branch
from
765ae5b to
67e86af
Compare
changelog: User-Facing Improvements, Forms, Use design system styling for all form inputs
aduth
force-pushed
the
aduth-design-system-field
branch
from
67e86af to
821e7f9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This modifies the SimpleForm form builder settings to display form inputs using design system CSS classes, allowing us to remove our ad hoc styling implementation.
Related Design System sync notes: https://docs.google.com/document/d/10b7Gis_VxYT3roR01MX4hwPa6-Tq29YBaLPIB3vWnUw/edit#heading=h.ecnbxdohywiz
📜 Testing Plan
👀 Screenshots
This would potentially affect many screens, but the "Sign in" page is shown below. There is not a visual impact on this screen.