Conversation
The upload step gets "submitted" regardless of whether or not it is actually visibile to the user (see the `update_if_skipping_upload` before action in the `DocAuthController`). This results in a submission event being logged regardless of whether the user actually submitted the step. This commit adds a param to the logs which will indicate to use that though there is a submission event the step was skipped an not visible to the user. This will be helpful in building a hybrid flow dashboard to determine how many users actually encounter the hybrid flow selection and what their choices are from that screen. [skip changelog]
jskinne3
approved these changes
Jan 25, 2023
Contributor
jskinne3
left a comment
jskinne3
left a comment
There was a problem hiding this comment.
This was badly needed, thank you! 👍
aduth
approved these changes
Jan 25, 2023
| FormResponse.new(success: true, errors: {}, extra: { destination: destination }) | ||
| FormResponse.new( | ||
| success: true, | ||
| errors: {}, |
Contributor
There was a problem hiding this comment.
Not strictly necessary or relevant, but since we're here: error is optional, could we just drop it?
Suggested change
| errors: {}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload step gets "submitted" regardless of whether or not it is actually visible to the user (see the
update_if_skipping_uploadbefore action in theDocAuthController). This results in a submission event being logged regardless of whether the user actually submitted the step.This commit adds a param to the logs which will indicate to use that though there is a submission event the step was skipped and not visible to the user. This will be helpful in building a hybrid flow dashboard to determine how many users actually encounter the hybrid flow selection and what their choices are from that screen.