Skip to content

LG-8703 use shared wait.html.erb, remove duplicates#7702

Merged
soniaconnolly merged 2 commits intomainfrom
sonia-lg-8703
Jan 25, 2023
Merged

LG-8703 use shared wait.html.erb, remove duplicates#7702
soniaconnolly merged 2 commits intomainfrom
sonia-lg-8703

Conversation

@soniaconnolly
Copy link
Contributor

🎫 Ticket

LG-8703, subtask of LG-7401

🛠 Summary of changes

PhoneController had a duplicate of the VerifyInfo wait.html.erb file, so change to use the shared version.
app/views/idv/gpo also had a duplicate that's unused, so remove it.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Create user
  • Test unsupervised proofing, confirm that phone step works as expected
  • Create another user (or start over)
  • Confirm that gpo flow works as expected

@soniaconnolly soniaconnolly marked this pull request as ready for review January 25, 2023 22:20
@soniaconnolly soniaconnolly requested a review from a team January 25, 2023 22:20
Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love negative line count PRs 🦋

@soniaconnolly soniaconnolly merged commit a6d4e13 into main Jan 25, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-8703 branch January 25, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants