Only allow email parameter in SessionsController#new#7690
Merged
mitchellhenke merged 1 commit intomainfrom Jan 24, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/explicit-password-hashing
branch
from
4b83856 to
5d9eeb8
Compare
zachmargolis
approved these changes
Jan 24, 2023
mitchellhenke
force-pushed
the
mitchellhenke/explicit-password-hashing
branch
from
5d9eeb8 to
0aef49d
Compare
mitchellhenke
changed the title
mitchellhenke
commented
Jan 24, 2023
Contributor
Author
There was a problem hiding this comment.
For any auth attempt, we want to run an scrypt hash exactly once.
This and the line above are helpful because they catch both the case where we may hash multiple times and the case where we hash zero times.
changelog: Internal, Performance, Only allow email parameter in sessions controller
mitchellhenke
force-pushed
the
mitchellhenke/explicit-password-hashing
branch
from
0aef49d to
55765d8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Following some of the changes in #7621 and #7657, we noticed that the
password=function can unnecessarily digest and encrypt the password, which is an expensive operation. This PR overrides thesign_in_paramsmethod from Devise so that we only pass theemailparameter to avoid an unnecessary call topassword=