Skip to content

Remove JavaScript decorators package#7688

Merged
aduth merged 1 commit intomainfrom
aduth-rm-once-decorator
Jan 24, 2023
Merged

Remove JavaScript decorators package#7688
aduth merged 1 commit intomainfrom
aduth-rm-once-decorator

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jan 24, 2023

🛠 Summary of changes

Removes the @18f/identity-decorators JavaScript package and updates the single remaining usage to remove the memoization usage.

Why?

  • While the once decorator was meant to be used as a memoization technique, it may have been a premature optimization for our current usage.
  • The TC39 decorator proposal is not final, and our implementation targeted a now-deprecated version of the proposed specification, and would eventually require a rewrite.
  • Because decorators are currently non-standard to the language, it could create onboarding barriers for new developers.
  • Reduces compiled bundle size, number of dependencies, and complexity of the build pipeline.

📜 Testing Plan

  • yarn test

changelog: Internal, Performance, Reduce size of JavaScript assets
@aduth aduth merged commit 11f3080 into main Jan 24, 2023
@aduth aduth deleted the aduth-rm-once-decorator branch January 24, 2023 15:17
@mdiarra3 mdiarra3 mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants