Deploy RC 246 to Prod

app/assets/stylesheets/components/_form.scss

@@ -1,38 +1,3 @@
-$radio-checkbox-space: 1.5rem;
-
-@include at-media('tablet') {
-  input,
-  select {
-    font-size: $form-field-font-size-sm;
-  }
-}
-
-.field {
-  background-color: #f2f9ff;
-  border-style: solid;
-  border-width: $border-width;
-  border-color: $border-color;
-  border-radius: $border-radius;
-  color: color('ink');
-  font-weight: $bold-font-weight;
-  margin-top: units(0.5);
-
-  &[type='number'],
-  &.phone {
-    @include u-font-family('mono');
-  }
-
-  &:focus {
-    border-color: color('primary');
-    box-shadow: 0 0 0 2px rgba(color('primary'), 0.5);
-    outline: none;
-  }
-
-  &.usa-input--error {
-    @include u-border($theme-input-state-border-width, 'error');
-  }
-}
-
 input::-webkit-outer-spin-button,
 input::-webkit-inner-spin-button {
   /* stylelint-disable-next-line property-no-vendor-prefix */
@@ -53,13 +18,3 @@ input::-webkit-inner-spin-button {
     margin-left: 0;
   }
 }
-
-// Upstream: https://github.com/18F/identity-style-guide/pull/325
-.usa-input {
-  margin-top: units(0.5);
-}
-
-// Upstream: https://github.com/18F/identity-style-guide/pull/325
-.usa-hint {
-  margin: 0;
-}

app/assets/stylesheets/design-system-waiting-room.scss

@@ -1,65 +1,5 @@
 // To be removed once design system incorporates styles included below.
 
-// basscss-base-forms
-//------------------------------------------------
-@mixin input-styles() {
-  height: 3rem;
-  padding: 0.5rem 1rem;
-  vertical-align: middle;
-}
-
-input[type='text'],
-input[type='date'],
-input[type='datetime'],
-input[type='datetime-local'],
-input[type='email'],
-input[type='month'],
-input[type='number'],
-input[type='password'],
-input[type='search'],
-input[type='tel'],
-input[type='time'],
-input[type='url'],
-input[type='week'] {
-  @include input-styles;
-  -webkit-appearance: none;
-}
-
-select {
-  @include input-styles;
-
-  // all below displays custom arrow and is pulled from:
-  // https://github.com/uswds/uswds/blob/develop/packages/usa-select/src/styles/_usa-select.scss
-  @include add-background-svg('usa-icons/unfold_more');
-  appearance: none;
-  background-color: color('white');
-  background-position: right units(1) center;
-  background-size: units(2.5);
-  padding-right: units(4);
-
-  &::-ms-expand {
-    display: none;
-  }
-
-  // Show default webkit style on select element when autofilled to show icon
-  &:-webkit-autofill {
-    appearance: menulist;
-  }
-
-  // Remove dotted outline from select element on focus in Firefox
-  &:-moz-focusring {
-    color: transparent;
-    text-shadow: 0 0 0 color('black');
-  }
-
-  // Necessary to show chevron in forced colors mode in modern browsers
-  @media (forced-colors: active) {
-    appearance: listbox;
-    background-image: none;
-    padding-right: 0;
-  }
-}
-
 //basscss-base-typography
 //------------------------------------------------
 h1,
@@ -72,16 +12,9 @@ h6 {
   margin-bottom: 0.5em;
 }
 
-p {
-  margin-top: 0;
-  margin-bottom: 1rem;
-}
-
-dl,
-ol,
+p,
 ul {
   margin-top: 0;
-  margin-bottom: 1rem;
 }
 
 // basscss-utility-typography

app/assets/stylesheets/variables/_app.scss

@@ -1,5 +1,4 @@
 $line-height: 1.5 !default;
-$bold-font-weight: bold !default;
 
 $h1: 1.5rem !default;
 $h2: 1.25rem !default;
@@ -15,14 +14,9 @@ $sm-h4: 1rem !default;
 $sm-h5: 0.875rem !default;
 $sm-h6: 0.75rem !default;
 
-$form-field-font-size-sm: 1.25rem !default;
-
-$border-width: 1px !default;
-$border-radius: 3px !default;
 $border-radius-md: 6px !default;
 $border-radius-xl: 16px !default;
 $border-radius-xxl: 24px !default;
-$border-color: #cedced !default;
 
 $container-skinny-width: 620px !default;
 $container-xskinny-width: 416px !default;

app/controllers/frontend_log_controller.rb

@@ -50,6 +50,6 @@ def valid_event?
   end
 
   def valid_payload?
-    !log_params[:payload].nil?
+    params[:payload].nil? || !log_params[:payload].nil?
   end
 end

app/controllers/idv/gpo_controller.rb

@@ -45,6 +45,9 @@ def step_indicator_current_step
     end
 
     def update_tracking
+      Funnel::DocAuth::RegisterStep.new(current_user.id, current_sp).
+        call(:usps_letter_sent, :update, true)
+
       analytics.idv_gpo_address_letter_requested(resend: resend_requested?)
       irs_attempts_api_tracker.idv_gpo_letter_requested(resend: resend_requested?)
       create_user_event(:gpo_mail_sent, current_user)

app/controllers/idv/in_person/usps_locations_controller.rb

@@ -14,7 +14,6 @@ class UspsLocationsController < ApplicationController
       # retrieve the list of nearby IPP Post Office locations with a POST request
       def index
         response = []
-
         begin
           if IdentityConfig.store.arcgis_search_enabled
             candidate = UspsInPersonProofing::Applicant.new(
@@ -26,12 +25,17 @@ def index
           else
             response = proofer.request_pilot_facilities
           end
+          render json: response.to_json
         rescue => err
-          Rails.logger.warn(err)
-          response = proofer.request_pilot_facilities
+          analytics.idv_in_person_locations_request_failure(
+            exception_class: err.class,
+            exception_message: err.message,
+            response_body_present: err.respond_to?(:response_body) && err.response_body.present?,
+            response_body: err.respond_to?(:response_body) && err.response_body,
+            response_status_code: err.respond_to?(:response_status) && err.response_status,
+          )
+          render json: {}, status: :internal_server_error
         end
-
-        render json: response.to_json
       end
 
       def proofer

app/controllers/idv/phone_controller.rb

@@ -20,7 +20,7 @@ def new
         analytics.idv_phone_of_record_visited
         render :new, locals: { gpo_letter_available: gpo_letter_available }
       elsif async_state.in_progress?
-        render :wait
+        render 'shared/wait'
       elsif async_state.missing?
         analytics.proofing_address_result_missing
         flash.now[:error] = I18n.t('idv.failure.timeout')
@@ -32,6 +32,10 @@ def new
 
     def create
       result = idv_form.submit(step_params)
+
+      Funnel::DocAuth::RegisterStep.new(current_user.id, current_sp).
+        call(:verify_phone, :update, result.success?)
+
       analytics.idv_phone_confirmation_form_submitted(**result.to_h)
       irs_attempts_api_tracker.idv_phone_submitted(
         success: result.success?,

app/controllers/idv/review_controller.rb

@@ -1,6 +1,7 @@
 module Idv
   class ReviewController < ApplicationController
     before_action :personal_key_confirmed
+    before_action :confirm_verify_info_complete
 
     include IdvStepConcern
     include StepIndicatorConcern
@@ -124,6 +125,13 @@ def password
       params.fetch(:user, {})[:password].presence
     end
 
+    def confirm_verify_info_complete
+      if IdentityConfig.store.doc_auth_verify_info_controller_enabled &&
+         !idv_session.resolution_successful
+        redirect_to idv_verify_info_url
+      end
+    end
+
     def personal_key_confirmed
       return unless current_user
       return unless current_user.active_profile.present? && need_personal_key_confirmation?

app/controllers/idv/session_errors_controller.rb

@@ -36,6 +36,8 @@ def ssn_failure
 
     def throttled
       @expires_at = Throttle.new(user: effective_user, throttle_type: :idv_doc_auth).expires_at
+      analytics.throttler_rate_limit_triggered(throttle_type: :idv_doc_auth)
+      irs_attempts_api_tracker.idv_document_upload_rate_limited
     end
 
     private