LG-8697 Clean up StringRedacter and replace duplicated redact() methods#7699
Merged
soniaconnolly merged 7 commits intomainfrom Jan 25, 2023
Merged
LG-8697 Clean up StringRedacter and replace duplicated redact() methods#7699soniaconnolly merged 7 commits intomainfrom
soniaconnolly merged 7 commits intomainfrom
Conversation
[skip changelog]
Move test from NewPhoneForm to new StringRedacter spec
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
eric-gade
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8697
🛠 Summary of changes
PR #7686 added a StringRedacter Concern to replace duplicated redact() calls, and used it in the new VerifyInfoController. Move it to app/services and use it in NewPhoneForm and the old VerifyBaseStep.
@zachmargolis and I have discussed this at length over at PR #7683 and he's happy with the code as it is now. This is the same commits cherry-picked onto a new branch off of main now that PR #7686 is merged.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.