Merged
Conversation
This change allows us to control whether or not we call the VA API mock proofer or a live VA API endpoint. changelog: Upcoming Features, Inherited Proofing, Add Feature Flag to Conditionally Call Mock API for VA User Data (LG-7623)
…ect Logout prevent_logout_redirect parameter (#7001)
changelog: Internal, Attempts API, Standardize events name
[skip changelog] * Add back in weight Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* Recompile Sass after exception when watching files **Why**: So that a developer has an opportunity to fix a compilation error, and so that they're not confused when their changes are not reflected in the running application process. changelog: Internal, Build Tooling, Recompile CSS after error in local development * Use "in" operator for Sass exception narrowing A bit clearer to interpret I think
[skip changelog]
https://cm-jira.usa.gov/browse/LG-7602 This is a supporting change for the LG-7602 feature for Inherited Proofing (IP) where user PII needs to be stored in session for IP flow steps and subsequent IDV workflow flow steps that need this information for (example) Lexis Phone Finder look ups. This change exposes a #user_pii method that retuns a Hash suitable to be stored in the idv_session and flow_session[:pii_from_user] (minus :uuid). The data mapped to the user PII returned from this method is Service Provider (SP)-specific in that the SP API returning the user PII may be returned having data keys that differ from what we need; consequently, create a mapper service for this, but that would disconnect what the SP service returns hash-wise. The Form knows about this, so it may be better suited "as is". changelog: Upcoming Features, Inherited Proofing, Pull VA IP Data and Store It In Session (LG-7602)
* expand metrics for USPS proofing attempts * LG-7275 Expand metrics for USPS proofing attempts changelog: Internal, In-person proofing, expand metrics for proofing attempts * enumerate params from analytics methods * refactor usps proofing tests to be DRYer * clean up usps proofing job and spec * tweak fixtures for expired id & unsupported status * clean up formatting and fixture
…irming new email address for existing account (#7019)
…cern refactor) 2 of 3 (#7012) * https://cm-jira.usa.gov/browse/LG-7602 This is a supporting change for the LG-7602 feature for Inherited Proofing (IP). The user's PII needs to be obtained from the Service Provider in our Inherited Proofing process Flow Steps. Identifying whether or not an Inherited Proofing SP request is in progress, needs access to the decorated_session, which currently takes place in the InheritedProofingConcern. It makes sense (for how), to serve up the Service Provider Services and Forms in this concern, since we can easily identify the Service Provider here also; we can think about placing this code in a SP Service and Form factory or something similar later. changelog: Upcoming Features, Inherited Proofing, Pull VA IP Data and Store It In Session (LG-7602) * Update our scripts to recognize new param to server
* Include U.S. territories in allowed countries for IdV phone changelog: Bug Fixes, Identity Verification, Allow U.S. territory numbers for IdV phone step * Use form instance for allowed countries * Only validate unsupported delivery methods if all unsupported * limit delivery options to phone number capabilities * Add regression coverage for "valid_phone_for_allowed_countries?" fix * Add test coverage for updated all-method-unsupported logic * Add test coverage for conditional field visibility * Check confirmed phones for PhoneNumberCapabilities initializer * Remove unnecessary memoization Conflicting variable name in "#new", not necessary anyways since we use it once in assignment, and helps collapse lines * Update spec expected error message for unsupported country * Fix OTP delivery method re-render on invalid create * Validate region regardless of number of supported countries We now support multiple. "valid country" should apply based on the selected country code regardless of how many countries are supported * Update server-side logic for U.S. number constraint error message * Fix empty errors value in spec assertion * Add phone analytics to phone finder * rename address proofing country codes constant and make it configurable * fix specs * JavaScript this.isConnected fix Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
* create pr template * changelog: Internal, In-person proofing, create template for PRs * drop the reference to jira
…State) 3 of 3 (#7022) * Include mixins needed for Inherited Proofing flow Specifically, obtaining user PII from the service provider and flow state support, including session massaging in preparation for IDV unattended work fllow. changelog: Upcoming Features, Inherited Proofing, Pull VA IP Data and Store It In Session (LG-7602) * Set the initial session for our flow This sets up session for the subsequent Inherited Proofing (IP) work flow/flow steps. * Add mixin to obtain user pii needed In order to proof our Inherited Proofing user: NOTE: the use of InheritedProofingConcern #inherited_proofing_service, members via its inclusion in the InheritedProofingController. Add delegations needed for conveinient access to controller and idv_session from InheritedProofingBaseStep so that we have these in any Flow Step we need them. * Add a mixin to manage the user pii and flow session This mixin provides a simple means to store user pii into the flow_session[:pii_from_user] and manage idv_session session data in preparation for IDV workflow handoff. * Refactor the AgreementStep to save user pii To session. Consume previously added UserPiiManagable mixin and 1) Save the user pii to session in the #call method 2) Return the FormResponse from the Service Provider API call to obtain user pii, so that it can be processed by the base class e.g. merged in with the Flow Step Form FormResponse and passed to analytics properly/perform error handling.. * Refactor specs to accomodate changes The Inherited Proofing (IP) flow steps now need current_user to be populated as would be the case in a real-life scenario as the user would have created an account and logged in before being redirected to the IP work flow. This change sets up current_user to create a real-live scenario. Specs also test to make sure flow steps are working regardless of the IdentityConfig.store.va_inherited_proofing_mock_enabled setting, although this may be sufficiently covered by the spec/controllers/concerns/inherited_proofing_concern_spec.rb specs.
* Change text * add text, rule, and styling for "First time using Login.gov? Add text, styling, and HTML for "First time using Login.gov?" * add translation for "First time using Login.gov?" * Add styling and adjust margin for buttons and text * delete unnecessary CSS and use USWDS classes Changelog: Improvements, User experience, Make CTA button more prominent [LG-6387] * standardize with use of em over px * Fix lint, replace login.gov with app name * add bg white to span using uswds class * Fix app name syntax * Use USWDS class for border-bottom * address code review comment * restructure text * changelog changelog: Improvements, UX experience, make CTA more prominent * fix margin between buttons and text Co-authored-by: Jack Cody <jack.cody@gsa.gov> Co-authored-by: Jessica Dembe <jessica.dembe@gsa.gov>
* LG-7417 Standardize failure responses changelog: Internal, Attempts API, Standardize events
- Follow-up to #7019 to prevent similar bugs in the future [skip changelog]
[skip changelog]
* Remove feature specs related to FSMv2 **Why**: The code for this feature is slated for removal (LG-7386). Until that can be prioritized, it'd be useful to remove feature specs since they prolong the runtime of continuous integration builds * Add changelog changelog: Internal, Automated Testing, Improve performance of automated tests
* Send the address to AAMVA This commit starts sending an address to AAMVA to validate. The verification still succeeds even if the address fails to match. This is because MVAs do not reliably perform address verification. The address results are included in the hash returned from `Proofing::Aamva::Responses::VerificationResponse#verification_results`. These can be used downstream to allow the address to be used for validation when other proofers are unable to verify an address. [skip changelog] * Only get the 5 digit zipcode * unbreak things * no more #warns * get the proofing specs passing for real this time * add address line 2 to the request body * parse address line 2 from the response * more address line 2 cleanups
* Add feature spec that makes sure mock JS works * Enable for all proofing in development by default * Use currentScript to avoid scraping DOM * Use react effects, hooks * Update ddp mock proofer - no more magic SSNs, only results from redis changelog: Internal, Device Profiling, Add ability to select mock device profiling response from UI Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
**Why**: To help avoid developer toil associated with crafting commit messages. Changelog:Internal,Changelog,Improve changelog tool flexibility for commit messages
* update alt tag to login.gov logo * update user_mailer.html spec to include text for img alt text * [skip changelog] * use var * move alt text to i18l files * update spec * update untranslated keys
* string translations added * fraud email template * update string used in fraud erb file * update strings so hyperlink works * add check to send alternate failed email * add test for new email to proofing results job spec * add new failed email test to user mailer spec * remove first_name from email as it's not available at this point of the process * Improvements, GetUspsProofingResultsJob, add additonal failure email * changed hi to hello * remove erroneous first_name from user mailer spec * change deliver now or later to deliver later * change fraudSuspected to boolean and switched back to deliver_now_or_later * change back to deliver_later * lint changes * adding suggestions * new line * remove line * Improvement, User Mailer, send suspected fraud failure email * changelog:Improvement, GetUspsProofingResultsJob, send suspected fraud failure email * changelog: Improvement, GetUspsProofingResultsJob, send suspected fraud failure email * update login.gov to use const instead of str
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features